Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for false TF provider bug #6577

Open
nadove-ucsc opened this issue Sep 17, 2024 · 2 comments
Open

Remove workaround for false TF provider bug #6577

nadove-ucsc opened this issue Sep 17, 2024 · 2 comments
Labels
-- [priority] Low debt [type] A defect incurring continued engineering cost enh [type] New feature or request infra [subject] Project infrastructure like CI/CD, build and deployment scripts orange [process] Done by the Azul team spike:1 [process] Spike estimate of one point

Comments

@nadove-ucsc
Copy link
Contributor

nadove-ucsc commented Sep 17, 2024

Currently, we use CloudFormation stack to manage the inspector rules that suppress findings for the Kibana, Cerebro, and Signing Proxy images (introduced in #5758). We initially tried to use the AWS Cloud Control provider plugin, but a confusing error message led us to abandon this approach and file a bug report against the provider.

Now, we've received a reply to the bug report. The proposed solution hasn't been tested yet, but if it works we could replace the CF stack implementation with our original design using CC.

@nadove-ucsc nadove-ucsc added the orange [process] Done by the Azul team label Sep 17, 2024
@hannes-ucsc
Copy link
Member

hannes-ucsc commented Sep 20, 2024

There were two bugs: 1) We specified invalid configuration and 2) the TF provider rejected it with a misleading error message. Spike to add FIXME referring to this issue in any of their PRs, then retriage. I already replied on the upstream issue, suggesting that the error message could be improved. Otherwise, this is low priority since we already use CF stacks elsewhere without issue.

@hannes-ucsc hannes-ucsc added enh [type] New feature or request debt [type] A defect incurring continued engineering cost infra [subject] Project infrastructure like CI/CD, build and deployment scripts -- [priority] Low spike:1 [process] Spike estimate of one point labels Sep 20, 2024
@nadove-ucsc
Copy link
Contributor Author

FIXME added to #6584

nadove-ucsc added a commit that referenced this issue Sep 21, 2024
@hannes-ucsc hannes-ucsc changed the title Remove workaround for false Terraform bug Remove workaround for false TF provider bug Sep 23, 2024
nadove-ucsc added a commit that referenced this issue Sep 24, 2024
nadove-ucsc added a commit that referenced this issue Sep 25, 2024
nadove-ucsc added a commit that referenced this issue Sep 26, 2024
nadove-ucsc added a commit that referenced this issue Sep 27, 2024
nadove-ucsc added a commit that referenced this issue Sep 28, 2024
nadove-ucsc added a commit that referenced this issue Oct 1, 2024
achave11-ucsc pushed a commit that referenced this issue Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- [priority] Low debt [type] A defect incurring continued engineering cost enh [type] New feature or request infra [subject] Project infrastructure like CI/CD, build and deployment scripts orange [process] Done by the Azul team spike:1 [process] Spike estimate of one point
Projects
None yet
Development

No branches or pull requests

2 participants