Skip to content

Commit 3aa629e

Browse files
committed
use the new config to decide which service to use
1 parent ef8f17f commit 3aa629e

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

tracer/src/Datadog.Trace/Ci/TestOptimizationTracerManagerFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ protected override IAgentWriter GetAgentWriter(TracerSettings settings, IDogStat
107107
return new ApmAgentWriter(settings, updateSampleRates, discoveryService, traceBufferSize);
108108
}
109109

110-
protected override IDiscoveryService GetDiscoveryService(TracerSettings settings)
110+
internal override IDiscoveryService GetDiscoveryService(TracerSettings settings)
111111
=> _testOptimizationTracerManagement.DiscoveryService;
112112
}
113113
}

tracer/src/Datadog.Trace/TracerManagerFactory.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -458,9 +458,6 @@ private static string GetUrl(TracerSettings settings)
458458
}
459459
}
460460

461-
protected virtual IDiscoveryService GetDiscoveryService(TracerSettings settings)
462-
=> DiscoveryService.Create(settings.Exporter);
463-
464461
internal static IDogStatsd CreateDogStatsdClient(TracerSettings settings, string serviceName, List<string> constantTags, string prefix = null, TimeSpan? telemtryFlushInterval = null)
465462
{
466463
try
@@ -507,6 +504,11 @@ internal static IDogStatsd CreateDogStatsdClient(TracerSettings settings, string
507504
}
508505
}
509506

507+
internal virtual IDiscoveryService GetDiscoveryService(TracerSettings settings)
508+
=> settings.AgentFeaturePollingEnabled ?
509+
DiscoveryService.Create(settings.Exporter) :
510+
NullDiscoveryService.Instance;
511+
510512
private static IDogStatsd CreateDogStatsdClient(TracerSettings settings, string serviceName)
511513
{
512514
var customTagCount = settings.GlobalTags.Count;

0 commit comments

Comments
 (0)