Add application test for pulse features with ROIs

(cherry picked from commit 82abef5)

Author: PierreRaybaut

datalab/adapters_plotpy/objects/scalar.py

@@ -442,26 +442,34 @@ def create_pulse_visualization_items(
         """
         items = []
         df = self.result_adapter.to_dataframe()
+
+        # Use the full signal data for all visualizations
+        # Note: pulse features x-coordinates (xstartmin, xendmin, etc.) are stored
+        # in the full signal coordinate system, even when computed on ROIs
+        x, y = obj.x, obj.y
+
         for _, row in df.iterrows():
             # Start baseline
             xs0, xs1 = row["xstartmin"], row["xstartmax"]
-            ys = pulse.get_range_mean_y(obj.x, obj.y, (xs0, xs1))
+            ys = pulse.get_range_mean_y(x, y, (xs0, xs1))
             if are_values_valid([xs0, xs1, ys]):
                 items.append(create_pulse_segment(xs0, ys, xs1, ys, "Start baseline"))
             # End baseline
             xe0, xe1 = row["xendmin"], row["xendmax"]
-            ye = pulse.get_range_mean_y(obj.x, obj.y, (xe0, xe1))
+            ye = pulse.get_range_mean_y(x, y, (xe0, xe1))
             if are_values_valid([xe0, xe1, ye]):
                 items.append(create_pulse_segment(xe0, ye, xe1, ye, "End baseline"))
             if "xplateaumin" in row and "xplateaumax" in row:
                 xp0, xp1 = row["xplateaumin"], row["xplateaumax"]
-                yp = pulse.get_range_mean_y(obj.x, obj.y, (xp0, xp1))
+                yp = pulse.get_range_mean_y(x, y, (xp0, xp1))
                 if are_values_valid([xp0, xp1, yp]):
                     items.append(create_pulse_segment(xp0, yp, xp1, yp, "Plateau"))
             for metric in ("x0", "x50", "x100"):
                 if metric in row:
-                    x = row[metric]
+                    x_crossing = row[metric]
                     metric_str = metric.replace("x", "x|<sub>") + "%</sub>"
-                    if are_values_valid([x]):
-                        items.append(create_pulse_crossing_marker("v", x, metric_str))
+                    if are_values_valid([x_crossing]):
+                        items.append(
+                            create_pulse_crossing_marker("v", x_crossing, metric_str)
+                        )
         return items

datalab/tests/features/signal/pulse_features_roi_app_test.py

@@ -0,0 +1,55 @@
+# Copyright (c) DataLab Platform Developers, BSD 3-Clause license, see LICENSE file.
+
+"""
+Pulse features with ROIs application test.
+"""
+
+# pylint: disable=invalid-name  # Allows short reference names like x, y, ...
+# guitest: show
+
+from __future__ import annotations
+
+from sigima.objects import SignalObj, TableResult
+from sigima.params import PulseFeaturesParam
+from sigima.tests.signal.pulse.pulse_features_roi_unit_test import (
+    check_results_equal,
+    generate_source_signal,
+)
+
+from datalab.gui.panel.signal import SignalPanel
+from datalab.tests import datalab_test_app_context
+
+
+def __extract_pulse_features(panel: SignalPanel, obj: SignalObj) -> TableResult:
+    """Extract pulse features."""
+    panel.objview.select_objects([obj])
+    param = PulseFeaturesParam()
+    param.update_from_obj(obj)
+    rdata = panel.processor.run_feature("extract_pulse_features", param)
+    assert len(rdata.results) == 1
+    return rdata.results[0]
+
+
+def test_pulse_features_roi_app():
+    """Pulse features with ROIs application test."""
+    with datalab_test_app_context(console=False) as win:
+        panel = win.signalpanel
+
+        # Test signal with multiple ROIs defined around peaks of the spectrum
+        sig = generate_source_signal()
+        panel.add_object(sig)
+        pf_sig = __extract_pulse_features(panel, sig)
+
+        # Extract ROIs in separate signals and test each one
+        panel.processor.run_feature("extract_roi", params=sig.roi.to_params(sig))
+        pf_extracted_sigs = []
+        for nb_sig in (2, 3, 4):
+            extracted_sig = panel.objmodel.get_object_from_number(nb_sig)
+            pf_extracted_sig = __extract_pulse_features(panel, extracted_sig)
+            pf_extracted_sigs.append(pf_extracted_sig)
+
+        check_results_equal(pf_sig, pf_extracted_sigs)
+
+
+if __name__ == "__main__":
+    test_pulse_features_roi_app()