Skip to content

Commit 683811d

Browse files
committed
Fix: store parameter metadata directly in result attributes
1 parent 174345f commit 683811d

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

datalab/adapters_metadata/base_adapter.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -172,11 +172,10 @@ def add_to(
172172
obj: Signal or image object
173173
param: Optional parameter dataset associated with this result
174174
"""
175-
result_dict = self.result.to_dict()
176-
# Store parameter metadata if provided (embedded in result dict)
175+
# Store parameter in result attrs (will be serialized with result)
177176
if param is not None:
178-
result_dict["param_json"] = gds.dataset_to_json(param)
179-
obj.metadata[self.metadata_key] = result_dict
177+
self.result.attrs["param_json"] = gds.dataset_to_json(param)
178+
obj.metadata[self.metadata_key] = self.result.to_dict()
180179

181180
def get_param(self, obj: SignalObj | ImageObj) -> gds.DataSet | None:
182181
"""Get parameter dataset associated with this result.
@@ -187,8 +186,7 @@ def get_param(self, obj: SignalObj | ImageObj) -> gds.DataSet | None:
187186
Returns:
188187
Parameter dataset if present, None otherwise
189188
"""
190-
result_dict = obj.metadata.get(self.metadata_key, {})
191-
param_json = result_dict.get("param_json")
189+
param_json = self.result.attrs.get("param_json")
192190
if param_json is not None:
193191
return gds.json_to_dataset(param_json)
194192
return None

0 commit comments

Comments
 (0)