Skip to content

Commit b1660b2

Browse files
committed
Fix: clear ROI for all selected images when ROI is cleared in ROI editor
Fix #160
1 parent 5a1bfe6 commit b1660b2

3 files changed

Lines changed: 7 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ See DataLab [roadmap page](https://datalab-platform.com/en/contributing/roadmap.
1515
* Fixed [Issue #153](https://github.com/DataLab-Platform/DataLab/issues/153) - Ignore `nan` values for signal normalization and statistics computations (both analysis result and interactive tool)
1616
* Fixed [Issue #158](https://github.com/DataLab-Platform/DataLab/issues/158) - When editing ROI of a list of images, the first image of the selection is shown (instead of the last as in the image panel)
1717
* Fixed [Issue #159](https://github.com/DataLab-Platform/DataLab/issues/159) - When selecting multiple images just after opening an HDF5 file, the "View in a new window" feature does not work (`KeyError` exception)
18+
* Fixed [Issue #160](https://github.com/DataLab-Platform/DataLab/issues/160) - When selecting multiple images and clearing ROI in ROI editor, only the first image is affected
1819

1920
## DataLab Version 0.19.0 ##
2021

cdl/core/gui/processor/base.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1090,7 +1090,8 @@ def edit_regions_of_interest(
10901090
if modified:
10911091
# If ROI has been modified, save ROI (not in "extract mode")
10921092
if edited_roi.is_empty():
1093-
obj.roi = None
1093+
for obj_i in objs:
1094+
obj_i.roi = None
10941095
else:
10951096
edited_roi = edited_roi.from_params(obj, group)
10961097
if not extract:

doc/locale/fr/LC_MESSAGES/contributing/changelog.po

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ msgid ""
77
msgstr ""
88
"Project-Id-Version: DataLab \n"
99
"Report-Msgid-Bugs-To: \n"
10-
"POT-Creation-Date: 2025-04-07 18:11+0200\n"
10+
"POT-Creation-Date: 2025-04-07 18:28+0200\n"
1111
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
1212
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
1313
"Language: fr\n"
@@ -57,6 +57,9 @@ msgstr "Correction de l'[Issue #158](https://github.com/DataLab-Platform/DataLab
5757
msgid "Fixed [Issue #159](https://github.com/DataLab-Platform/DataLab/issues/159) - When selecting multiple images just after opening an HDF5 file, the \"View in a new window\" feature does not work (`KeyError` exception)"
5858
msgstr "Correction de l'[Issue #159](https://github.com/DataLab-Platform/DataLab/issues/159) - Lors de la sélection de plusieurs images juste après l'ouverture d'un fichier HDF5, la fonctionnalité \"Afficher dans une nouvelle fenêtre\" ne fonctionne pas (exception `KeyError`)"
5959

60+
msgid "Fixed [Issue #160](https://github.com/DataLab-Platform/DataLab/issues/160) - When selecting multiple images and clearing ROI in ROI editor, only the first image is affected"
61+
msgstr "Correction de l'[Issue #160](https://github.com/DataLab-Platform/DataLab/issues/160) - Lors de la sélection de plusieurs images et de l'effacement de la ROI dans l'éditeur de ROI, seule la première image est affectée"
62+
6063
msgid "DataLab Version 0.19.0"
6164
msgstr "DataLab Version 0.19.0"
6265

0 commit comments

Comments
 (0)