Skip to content

Commit db7ad47

Browse files
committed
fix(build): adjust translation compilation order in build script
1 parent d98929f commit db7ad47

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

scripts/build_exe.bat

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@ set REPODIR=%SCRIPTPATH%\..
2121
set CLONEDIR=%REPODIR%\..\%LIBNAME%-tempdir
2222
if exist %CLONEDIR% ( rmdir /s /q %CLONEDIR% )
2323
git clone -l -s . %CLONEDIR%
24+
25+
@REM Compile translations in cloned directory using dev environment (which has babel)
26+
@REM This must happen BEFORE pushd because run_with_env.py loads .env from current dir
27+
%PYTHON% scripts/run_with_env.py %PYTHON% -m guidata.utils.translations compile --name datalab --directory %CLONEDIR%
28+
2429
pushd %CLONEDIR%
2530

2631
@REM Backup PYTHONPATH
@@ -45,8 +50,7 @@ for %%s in (16 24 32 48 128 256) do (
4550
magick "%RESPATH%\tmp-*.png" "%RESPATH%\DataLab.ico"
4651
del "%RESPATH%\tmp-*.png"
4752

48-
@REM Compile translations
49-
%PYTHON% -m guidata.utils.translations compile --name datalab --directory .
53+
@REM Note: Translations were already compiled in the cloned directory using the dev environment
5054

5155
@REM Generate build manifest
5256
%PYTHON% scripts\generate_manifest.py

0 commit comments

Comments
 (0)