Fix #61: crash when importing multiple curve text file

Author: PierreRaybaut

CHANGELOG.md

@@ -3,6 +3,14 @@
 See DataLab [roadmap page](https://datalab-platform.com/en/contributing/roadmap.html)
 for future and past milestones.
 
+## DataLab Version 0.14.2 ##
+
+🛠️ Bug fixes:
+
+* Fixed [Issue #61](https://github.com/DataLab-Platform/DataLab/issues/61) - Text file import wizard: application crash when importing a multiple curve text file:
+  * This issue concerns a use case where the text file contains multiple curves
+  * This is now fixed and an automatic test has been added to prevent regressions
+
 ## DataLab Version 0.14.1 ##
 
 🎉 New domain name: [datalab-platform.com](https://datalab-platform.com)

cdl/data/tests/curve_formats/multiple_curves.csv

@@ -0,0 +1,29 @@
+time;PT380;TT382;2TT385;1TT385;TT383
+-1294.982;1254.853394;26.64377594;35.75617218;32.19374466;32.60350037
+-1294.884;1254.853394;26.64377594;35.75617218;32.19374466;32.60350037
+-1294.883;1254.853394;26.64377594;35.75617218;32.19374466;32.60350037
+-1294.876;1254.853394;26.64377594;35.75617218;32.19374466;32.60350037
+-1294.834;1254.853394;26.64377594;35.75617218;32.19374466;32.60350037
+-1294.805;1254.853394;26.64377594;35.75617218;32.19374466;32.60350037
+-1294.784;1254.853394;26.64377594;35.75617218;32.19374466;32.60350037
+-1294.756;1254.853394;26.64377594;35.75617218;32.19374466;32.60350037
+-1294.755;1254.853394;26.64033699;35.75617218;32.19374466;32.60350037
+-1294.684;1254.853394;26.64033699;35.75617218;32.19374466;32.60350037
+-1294.634;1254.853394;26.64033699;35.75617218;32.19374466;32.60350037
+-1294.633;1254.853394;26.63676262;35.75617218;32.19374466;32.60350037
+-1294.626;1254.853394;26.63676262;35.75617218;32.19374466;32.60350037
+-1294.584;1254.853394;26.63676262;35.74349594;32.19374466;32.60350037
+-1294.555;1254.853394;26.63676262;35.74349594;32.19374466;32.60350037
+-1294.506;1254.853394;26.63676262;35.74349594;32.19374466;32.60350037
+-1294.505;1254.853394;26.6340313;35.74349594;32.19374466;32.60350037
+-1294.484;1254.853394;26.6340313;35.74349594;32.19374466;32.60350037
+-1294.446;1254.853394;26.6340313;35.74349594;32.19374466;32.60350037
+-1294.444;1254.853394;26.6340313;35.74349594;32.19374466;32.60350037
+-1294.436;1254.853394;26.6340313;35.74349594;32.19374466;32.60350037
+-1294.432;1254.853394;26.6340313;35.74349594;32.19374466;32.60350037
+-1294.376;1254.853394;26.6340313;35.74349594;32.19374466;32.60350037
+-1294.356;1254.853394;26.6340313;35.74349594;32.19374466;32.60350037
+-1294.355;1254.853394;26.63006401;35.74349594;32.19374466;32.60350037
+-1294.331;1254.853394;26.63006401;35.74349594;32.19374466;32.60350037
+-1294.315;1254.853394;26.63006401;35.74349594;32.19374466;32.60350037
+-1294.311;1254.853394;26.63006401;35.74349594;32.19374466;32.60350037

cdl/tests/features/common/textimport_unit_test.py

@@ -30,6 +30,7 @@ def test_import_wizard():
     with qt_app_context():
         for destination, fname, otype in (
             ("image", "fiber.txt", ImageObj),
+            ("signal", "multiple_curves.csv", SignalObj),
             ("signal", "paracetamol.txt", SignalObj),
         ):
             path = get_test_fnames(fname)[0]
@@ -48,8 +49,13 @@ def test_import_wizard():
                 srcpge.source_widget.file_edit.editingFinished.emit()
                 wizard.go_to_next_page()
                 datapge = wizard.data_page
+                n_objs = 1
                 if fname == "fiber.txt":
                     datapge.param.delimiter_choice = " "
+                elif fname == "multiple_curves.csv":
+                    datapge.param.delimiter_choice = ";"
+                    datapge.param.skip_rows = 1
+                    n_objs = 5
                 else:
                     datapge.param.skip_rows = 10
                 datapge.param_widget.get()
@@ -59,7 +65,7 @@ def test_import_wizard():
                 wizard.go_to_next_page()
                 wizard.go_to_next_page()
                 wizard.accept()
-                assert len(wizard.get_objs()) == 1
+                assert len(wizard.get_objs()) == n_objs
                 assert isinstance(wizard.get_objs()[0], otype)
             elif exec_dialog(wizard):
                 for obj in wizard.get_objs():

cdl/widgets/textimport.py

@@ -358,7 +358,7 @@ def set_preview_data(
                 if len(data.shape) == 1:
                     h_headers = ["Y"]
                 elif first_col_is_x:
-                    if len(data.shape) == 2:
+                    if len(data[0]) == 2:
                         h_headers = ["X", "Y"]
                     else:
                         h_headers = ["X"] + [f"Y{i+1}" for i in range(len(data[0]) - 1)]