Fix validation status renaming issues

Author: PierreRaybaut

CHANGELOG.md

@@ -10,7 +10,7 @@ See DataLab [roadmap page](https://datalab-platform.com/en/contributing/roadmap.
   * Added new `@computation_function` decorator to mark and register computation functions
   * Renamed computation functions to remove redundant "compute_" prefix (e.g., `compute_fft` ➝ `fft`)
   * Added infrastructure for discovering computation functions via introspection
-  * Improved function naming in coordinate transformations (e.g., `cartesian2polar` ➝ `to_polar`)
+  * Improved function naming in coordinate transformations (e.g., `to_polar` ➝ `to_polar`)
   * Added type hints and improved documentation across computation modules
   * These changes improve code organization and maintainability while making the API more intuitive
   * Internal changes only - **no backward compatibility is maintained** for plugin developers

cdl/tests/features/images/operation_unit_test.py

@@ -68,23 +68,23 @@ def __create_n_images(n: int = 100) -> list[cdl.obj.ImageObj]:
 
 
 @pytest.mark.validation
-def test_image_sum() -> None:
-    """Image sum test."""
-    execenv.print("*** Testing image sum:")
+def test_image_addition() -> None:
+    """Image addition test."""
+    execenv.print("*** Testing image addition:")
     for ima1, ima2 in __iterate_image_couples():
         dtype1, dtype2 = ima1.data.dtype, ima2.data.dtype
         execenv.print(f"  {dtype1} += {dtype2}: ", end="")
         exp = ima1.data.astype(float) + ima2.data.astype(float)
         ima3 = cpi.addition([ima1, ima2])
-        check_array_result("Image sum", ima3.data, exp)
+        check_array_result("Image addition", ima3.data, exp)
     imalist = __create_n_images()
     n = len(imalist)
     ima3 = cpi.addition(imalist)
     res = ima3.data
     exp = np.zeros_like(ima3.data)
     for ima in imalist:
         exp += ima.data
-    check_array_result(f"  Sum of {n} images", res, exp)
+    check_array_result(f"  Addition of {n} images", res, exp)
 
 
 @pytest.mark.validation
@@ -289,36 +289,36 @@ def test_image_inverse() -> None:
 
 
 @pytest.mark.validation
-def test_image_abs() -> None:
+def test_image_absolute() -> None:
     """Image absolute value test."""
     execenv.print("*** Testing image absolute value:")
     for ima1 in __iterate_images():
         execenv.print(f"  abs({ima1.data.dtype}): ", end="")
         exp = np.abs(ima1.data)
         ima2 = cpi.absolute(ima1)
-        check_array_result("Image abs", ima2.data, exp)
+        check_array_result("Absolute value", ima2.data, exp)
 
 
 @pytest.mark.validation
-def test_image_re() -> None:
+def test_image_real() -> None:
     """Image real part test."""
     execenv.print("*** Testing image real part:")
     for ima1 in __iterate_images():
         execenv.print(f"  re({ima1.data.dtype}): ", end="")
         exp = np.real(ima1.data)
         ima2 = cpi.real(ima1)
-        check_array_result("Image re", ima2.data, exp)
+        check_array_result("Real part", ima2.data, exp)
 
 
 @pytest.mark.validation
-def test_image_im() -> None:
+def test_image_imag() -> None:
     """Image imaginary part test."""
     execenv.print("*** Testing image imaginary part:")
     for ima1 in __iterate_images():
         execenv.print(f"  im({ima1.data.dtype}): ", end="")
         exp = np.imag(ima1.data)
         ima2 = cpi.imag(ima1)
-        check_array_result("Image im", ima2.data, exp)
+        check_array_result("Imaginary part", ima2.data, exp)
 
 
 def __get_numpy_info(dtype: np.dtype) -> np.generic:
@@ -449,7 +449,7 @@ def test_image_rotate() -> None:
 
 
 if __name__ == "__main__":
-    test_image_sum()
+    test_image_addition()
     test_image_average()
     test_image_product()
     test_image_division()
@@ -461,9 +461,9 @@ def test_image_rotate() -> None:
     test_image_division_constant()
     test_image_arithmetic()
     test_image_inverse()
-    test_image_abs()
-    test_image_re()
-    test_image_im()
+    test_image_absolute()
+    test_image_real()
+    test_image_imag()
     test_image_astype()
     test_image_exp()
     test_image_log10()

cdl/tests/features/signals/operation_unit_test.py

@@ -53,16 +53,16 @@ def __create_one_signal_and_constant() -> tuple[
 
 
 @pytest.mark.validation
-def test_signal_sum() -> None:
-    """Signal sum test."""
+def test_signal_addition() -> None:
+    """Signal addition test."""
     slist = __create_n_signals()
     n = len(slist)
     s3 = cps.addition(slist)
     res = s3.y
     exp = np.zeros_like(s3.y)
     for s in slist:
         exp += s.y
-    check_array_result(f"Sum of {n} signals", res, exp)
+    check_array_result(f"Addition of {n} signals", res, exp)
 
 
 @pytest.mark.validation
@@ -161,23 +161,23 @@ def test_signal_inverse() -> None:
 
 
 @pytest.mark.validation
-def test_signal_abs() -> None:
+def test_signal_absolute() -> None:
     """Absolute value validation test."""
     s1 = __create_two_signals()[0]
     abs_signal = cps.absolute(s1)
     check_array_result("Absolute value", abs_signal.y, np.abs(s1.y))
 
 
 @pytest.mark.validation
-def test_signal_re() -> None:
+def test_signal_real() -> None:
     """Real part validation test."""
     s1 = __create_two_signals()[0]
     re_signal = cps.real(s1)
     check_array_result("Real part", re_signal.y, np.real(s1.y))
 
 
 @pytest.mark.validation
-def test_signal_im() -> None:
+def test_signal_imag() -> None:
     """Imaginary part validation test."""
     s1 = __create_two_signals()[0]
     im_signal = cps.imag(s1)
@@ -252,7 +252,7 @@ def test_signal_arithmetic() -> None:
 
 
 if __name__ == "__main__":
-    test_signal_sum()
+    test_signal_addition()
     test_signal_average()
     test_signal_product()
     test_signal_difference()
@@ -263,9 +263,9 @@ def test_signal_arithmetic() -> None:
     test_signal_difference_constant()
     test_signal_division_constant()
     test_signal_inverse()
-    test_signal_abs()
-    test_signal_re()
-    test_signal_im()
+    test_signal_absolute()
+    test_signal_real()
+    test_signal_imag()
     test_signal_astype()
     test_signal_exp()
     test_signal_log10()

cdl/tests/features/signals/processing_unit_test.py

@@ -82,7 +82,7 @@ def test_signal_reverse_x() -> None:
     check_array_result("ReverseX", dst.data, exp)
 
 
-def test_cartesian2polar() -> None:
+def test_to_polar() -> None:
     """Unit test for the cartesian to polar conversion."""
     title = "Cartesian2Polar"
     x = np.array([0.0, 1.0, 2.0, 3.0, 4.0])
@@ -100,7 +100,7 @@ def test_cartesian2polar() -> None:
     check_array_result(f"{title}|theta", theta, exp_theta)
 
 
-def test_polar2cartesian() -> None:
+def test_to_cartesian() -> None:
     """Unit test for the polar to cartesian conversion."""
     title = "Polar2Cartesian"
     r = np.array([0.0, np.sqrt(2.0), np.sqrt(8.0), np.sqrt(18.0), np.sqrt(32.0)])
@@ -119,7 +119,7 @@ def test_polar2cartesian() -> None:
 
 
 @pytest.mark.validation
-def test_signal_cartesian2polar() -> None:
+def test_signal_to_polar() -> None:
     """Validation test for the signal cartesian to polar processing."""
     title = "Cartesian2Polar"
     p = cdl.param.AngleUnitParam()
@@ -135,7 +135,7 @@ def test_signal_cartesian2polar() -> None:
 
 
 @pytest.mark.validation
-def test_signal_polar2cartesian() -> None:
+def test_signal_to_cartesian() -> None:
     """Validation test for the signal polar to cartesian processing."""
     title = "Polar2Cartesian"
     p = cdl.param.AngleUnitParam()
@@ -382,10 +382,10 @@ def test_signal_XY_mode() -> None:
 if __name__ == "__main__":
     test_signal_calibration()
     test_signal_swap_axes()
-    test_cartesian2polar()
-    test_polar2cartesian()
-    test_signal_cartesian2polar()
-    test_signal_polar2cartesian()
+    test_to_polar()
+    test_to_cartesian()
+    test_signal_to_polar()
+    test_signal_to_cartesian()
     test_signal_reverse_x()
     test_signal_normalize()
     test_signal_clip()

doc/locale/fr/LC_MESSAGES/api/proxy.po

@@ -605,7 +605,7 @@ msgstr ""
 msgid "Compute data linear calibration"
 msgstr ""
 
-msgid ":py:func:`~cdl.core.gui.processor.signal.SignalProcessor.compute_cartesian2polar`"
+msgid ":py:func:`~cdl.core.gui.processor.signal.SignalProcessor.compute_to_polar`"
 msgstr ""
 
 msgid "Convert cartesian to polar coordinates"
@@ -830,7 +830,7 @@ msgstr ""
 msgid "Compute phase spectrum"
 msgstr ""
 
-msgid ":py:func:`~cdl.core.gui.processor.signal.SignalProcessor.compute_polar2cartesian`"
+msgid ":py:func:`~cdl.core.gui.processor.signal.SignalProcessor.compute_to_cartesian`"
 msgstr ""
 
 msgid "Convert polar to cartesian coordinates"

doc/locale/fr/LC_MESSAGES/contributing/changelog.po

@@ -42,8 +42,8 @@ msgstr "Renommé les fonctions de calcul pour supprimer le préfixe redondant \"
 msgid "Added infrastructure for discovering computation functions via introspection"
 msgstr "Ajout d'une infrastructure pour découvrir les fonctions de calcul via l'introspection"
 
-msgid "Improved function naming in coordinate transformations (e.g., `cartesian2polar` ➝ `to_polar`)"
-msgstr "Amélioration de la nomination des fonctions dans les transformations de coordonnées (par exemple, `cartesian2polar` ➝ `to_polar`)"
+msgid "Improved function naming in coordinate transformations (e.g., `to_polar` ➝ `to_polar`)"
+msgstr "Amélioration de la nomination des fonctions dans les transformations de coordonnées (par exemple, `to_polar` ➝ `to_polar`)"
 
 msgid "Added type hints and improved documentation across computation modules"
 msgstr "Ajout de types d'indices et amélioration de la documentation dans les modules de calcul"

doc/locale/fr/LC_MESSAGES/features/general/remote.po

@@ -587,10 +587,10 @@ msgstr ""
 msgid "Reverse X axis with :py:func:`cdl.computation.signal.compute_reverse_x`"
 msgstr ""
 
-msgid "Convert cartesian to polar coordinates with :py:func:`cdl.computation.signal.compute_cartesian2polar`"
+msgid "Convert cartesian to polar coordinates with :py:func:`cdl.computation.signal.compute_to_polar`"
 msgstr ""
 
-msgid "Convert polar to cartesian coordinates with :py:func:`cdl.computation.signal.compute_polar2cartesian`."
+msgid "Convert polar to cartesian coordinates with :py:func:`cdl.computation.signal.compute_to_cartesian`."
 msgstr ""
 
 msgid "Normalize data with :py:func:`cdl.computation.signal.compute_normalize`"

doc/locale/fr/LC_MESSAGES/features/validation/status.po

@@ -208,13 +208,13 @@ msgstr ""
 msgid "`test_signal_calibration <https://github.com/DataLab-Platform/DataLab/blob/v0.20.0/cdl/tests/features/signals/processing_unit_test.py#L36>`_"
 msgstr ""
 
-msgid ":py:func:`compute_cartesian2polar <cdl.computation.signal.compute_cartesian2polar>`"
+msgid ":py:func:`compute_to_polar <cdl.computation.signal.compute_to_polar>`"
 msgstr ""
 
 msgid "Convert cartesian coordinates to polar coordinates"
 msgstr ""
 
-msgid "`test_signal_cartesian2polar <https://github.com/DataLab-Platform/DataLab/blob/v0.20.0/cdl/tests/features/signals/processing_unit_test.py#L121>`_"
+msgid "`test_signal_to_polar <https://github.com/DataLab-Platform/DataLab/blob/v0.20.0/cdl/tests/features/signals/processing_unit_test.py#L121>`_"
 msgstr ""
 
 msgid ":py:func:`compute_clip <cdl.computation.signal.compute_clip>`"
@@ -502,13 +502,13 @@ msgstr ""
 msgid "`test_signal_phase_spectrum <https://github.com/DataLab-Platform/DataLab/blob/v0.20.0/cdl/tests/features/signals/fft1d_unit_test.py#L161>`_"
 msgstr ""
 
-msgid ":py:func:`compute_polar2cartesian <cdl.computation.signal.compute_polar2cartesian>`"
+msgid ":py:func:`compute_to_cartesian <cdl.computation.signal.compute_to_cartesian>`"
 msgstr ""
 
 msgid "Convert polar coordinates to cartesian coordinates"
 msgstr ""
 
-msgid "`test_signal_polar2cartesian <https://github.com/DataLab-Platform/DataLab/blob/v0.20.0/cdl/tests/features/signals/processing_unit_test.py#L137>`_"
+msgid "`test_signal_to_cartesian <https://github.com/DataLab-Platform/DataLab/blob/v0.20.0/cdl/tests/features/signals/processing_unit_test.py#L137>`_"
 msgstr ""
 
 msgid ":py:func:`compute_power <cdl.computation.signal.compute_power>`"