Enhance metadata comparison by raising on differences in tests

PierreRaybaut · PierreRaybaut · commit e4fe7ce27af2 · 2025-10-15T13:25:13.000+02:00
diff --git a/datalab/tests/backbone/dictlistserial_app_test.py b/datalab/tests/backbone/dictlistserial_app_test.py
@@ -29,8 +29,8 @@ def test_dict_serialization():
                 execenv.print("Dictionary/List (de)serialization:")
                 oids = panel.objmodel.get_object_ids()
                 first_image = panel.objmodel[oids[0]]
-                assert helpers.compare_metadata(
-                    image.metadata, first_image.metadata.copy()
+                helpers.compare_metadata(
+                    image.metadata, first_image.metadata.copy(), raise_on_diff=True
                 )
 
 
diff --git a/datalab/tests/features/common/metadata_io_unit_test.py b/datalab/tests/features/common/metadata_io_unit_test.py
@@ -51,7 +51,9 @@ def test_metadata_io_unit():
 
                 panel.import_metadata_from_file(fname)
                 execenv.print("Check metadata export <--> import features:")
-                helpers.compare_metadata(orig_metadata, ima.metadata)
+                helpers.compare_metadata(
+                    orig_metadata, ima.metadata, raise_on_diff=True
+                )
 
 
 if __name__ == "__main__":

Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,8 @@ def test_dict_serialization():`
`29`	`29`	`execenv.print("Dictionary/List (de)serialization:")`
`30`	`30`	`oids = panel.objmodel.get_object_ids()`
`31`	`31`	`first_image = panel.objmodel[oids[0]]`
`32`		`- assert helpers.compare_metadata(`
`33`		`- image.metadata, first_image.metadata.copy()`
	`32`	`+ helpers.compare_metadata(`
	`33`	`+ image.metadata, first_image.metadata.copy(), raise_on_diff=True`
`34`	`34`	`)`
`35`	`35`
`36`	`36`