Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

Finalize Native Threading Model as it affects DMCHandler() #94

Open
fuxingloh opened this issue Sep 14, 2022 · 2 comments
Open

Finalize Native Threading Model as it affects DMCHandler() #94

fuxingloh opened this issue Sep 14, 2022 · 2 comments
Labels
area/ain issues/pr that requires changes on the DeFiCh/ain codebase. kind/feature New feature request triage/accepted Triage has been accepted

Comments

@fuxingloh
Copy link
Contributor

What would you like to be added:

Finalize Native DeFiCh/ain threading model when implementing class DMCHandler for outgoing RPCs from the native side. This might be a non-code change, but it's open for discussion with no resolution in mind.

Why is this needed:

While on the native side, the minter runs on single-threaded at the moment. The current model limits all node operators to run on a single thread. While this is perfectly fine and DMC can keep the same threading model. Coupling model with DMC side where block creation can be more expensive it might create less than ideal performance for DeFiChain network.

That being said, DMC doesn't have any compute-intensive module (e.g., no staking model). It might be trivial and a non-issue. We could also optimize DMC to always "prepare" a block and finalize it on Native side without having to compute at "mining (staking)" time.

@fuxingloh fuxingloh added triage/accepted Triage has been accepted kind/feature New feature request area/ain issues/pr that requires changes on the DeFiCh/ain codebase. labels Sep 14, 2022
@fuxingloh fuxingloh added this to the MetaChain MainNet milestone Sep 14, 2022
@fuxingloh
Copy link
Contributor Author

The outcome is to assess and understand what we should do there. Should we change anything? Does it matter? Does the threading model on DNC affects DMC?

@mambisi
Copy link

mambisi commented Nov 23, 2022

Thanks @fuxingloh I will look into it a give feedback

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/ain issues/pr that requires changes on the DeFiCh/ain codebase. kind/feature New feature request triage/accepted Triage has been accepted
Projects
None yet
Development

No branches or pull requests

2 participants