Nits

Author: SouthEndMusic

Manifest.toml

@@ -2,7 +2,7 @@
 
 julia_version = "1.11.3"
 manifest_format = "2.0"
-project_hash = "9a6b7d65fd9b1cb3c7c8243cb7719dc6ca804be0"
+project_hash = "6e40b7b91158ba32037907b31496430241597a25"
 
 [[deps.ADTypes]]
 git-tree-sha1 = "e2478490447631aedba0823d4d7a80b2cc8cdb32"
@@ -1362,16 +1362,12 @@ deps = ["ADTypes", "CommonSolve", "ConcreteStructs", "FastClosures", "LinearAlge
 git-tree-sha1 = "97d502765cc5cf3a722120f50da03c2474efce04"
 uuid = "87fe0de2-c867-4266-b59a-2f0a94fc965b"
 version = "0.1.4"
-weakdeps = ["LineSearches"]
 
     [deps.LineSearch.extensions]
     LineSearchLineSearchesExt = "LineSearches"
 
-[[deps.LineSearches]]
-deps = ["LinearAlgebra", "NLSolversBase", "NaNMath", "Parameters", "Printf"]
-git-tree-sha1 = "e4c3be53733db1051cc15ecf573b1042b3a712a1"
-uuid = "d3d80556-e9d4-5f37-9878-2ab0fcc64255"
-version = "7.3.0"
+    [deps.LineSearch.weakdeps]
+    LineSearches = "d3d80556-e9d4-5f37-9878-2ab0fcc64255"
 
 [[deps.LinearAlgebra]]
 deps = ["Libdl", "OpenBLAS_jll", "libblastrampoline_jll"]
@@ -1584,12 +1580,6 @@ git-tree-sha1 = "491bdcdc943fcbc4c005900d7463c9f216aabf4c"
 uuid = "d8a4904e-b15c-11e9-3269-09a3773c0cb0"
 version = "1.6.4"
 
-[[deps.NLSolversBase]]
-deps = ["DiffResults", "Distributed", "FiniteDiff", "ForwardDiff"]
-git-tree-sha1 = "a0b464d183da839699f4c79e7606d9d186ec172c"
-uuid = "d41bc354-129a-5804-8e4c-c37616107c6c"
-version = "7.8.3"
-
 [[deps.NaNMath]]
 deps = ["OpenLibm_jll"]
 git-tree-sha1 = "cc0a5deefdb12ab3a096f00a6d42133af4560d71"

core/src/config.jl

@@ -293,7 +293,7 @@ function function_accepts_kwarg(f, kwarg)::Bool
 end
 
 "Create an OrdinaryDiffEqAlgorithm from solver config"
-function algorithm(solver::Solver; u0 = [])::OrdinaryDiffEqAlgorithm
+function algorithm(solver::Solver)::OrdinaryDiffEqAlgorithm
     algotype = get(algorithms, solver.algorithm, nothing)
     if algotype === nothing
         options = join(keys(algorithms), ", ")

core/src/model.jl

@@ -145,7 +145,7 @@ function Model(config::Config)::Model
     @reset parameters.u_prev_saveat = zero(u0)
 
     # The Solver algorithm
-    alg = algorithm(config.solver; u0)
+    alg = algorithm(config.solver)
 
     # Synchronize level with storage
     set_current_basin_properties!(du0, u0, parameters, t0)

core/src/util.jl

@@ -52,7 +52,7 @@ end
 """
 Compute the level of a basin given its storage.
 """
-function get_level_from_storage(basin::Basin, state_idx::Int, storage)
+function get_level_from_storage(basin::Basin, state_idx::Int, storage::T)::T where {T}
     storage_to_level = basin.storage_to_level[state_idx]
     if storage >= 0
         return storage_to_level(storage)