Chat File: Inherits DOMComponent #31446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR changes the File component in DevExtreme's Chat widget to inherit from DOMComponent instead of Widget, and adds support for state options (activeStateEnabled, focusStateEnabled, hoverStateEnabled) that are proxied to the internal download button.
Key changes:
- Changed base class from
WidgettoDOMComponentfor the File component - Added three state options that control interaction states and are forwarded to the download button
- Added comprehensive test coverage for the new state options
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/ui/chat/file_view/file.ts | Updated File component to extend DOMComponent, added state option properties, and configured download button to use these options |
| packages/devextreme/testing/tests/DevExpress.ui.widgets/chatParts/file.tests.js | Added test suite for state options including initialization tests, runtime update tests, and default value verification |
r-farkhutdinov
previously approved these changes
Oct 23, 2025
marker-dao
force-pushed
the
25_2_file_update_inheritance
branch
from
5f20765 to
24bb606
Compare
r-farkhutdinov
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.