Skip to content

Commit 50b4630

Browse files
author
Khaled Osman
committed
migrate from tslint to angular-eslint:builder
1 parent f2147eb commit 50b4630

File tree

6 files changed

+961
-327
lines changed

6 files changed

+961
-327
lines changed

.eslintrc.json

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
{
2+
"root": true,
3+
"ignorePatterns": [
4+
"projects/**/*"
5+
],
6+
"overrides": [
7+
{
8+
"files": [
9+
"*.ts"
10+
],
11+
"parserOptions": {
12+
"project": [
13+
"tsconfig.json",
14+
"e2e/tsconfig.json"
15+
],
16+
"createDefaultProgram": true
17+
},
18+
"extends": [
19+
"plugin:@angular-eslint/recommended",
20+
"plugin:@angular-eslint/template/process-inline-templates"
21+
],
22+
"rules": {
23+
"@angular-eslint/component-selector": [
24+
"error",
25+
{
26+
"prefix": "app",
27+
"style": "kebab-case",
28+
"type": "element"
29+
}
30+
],
31+
"@angular-eslint/directive-selector": [
32+
"error",
33+
{
34+
"prefix": "app",
35+
"style": "camelCase",
36+
"type": "attribute"
37+
}
38+
]
39+
}
40+
},
41+
{
42+
"files": [
43+
"*.html"
44+
],
45+
"extends": [
46+
"plugin:@angular-eslint/template/recommended"
47+
],
48+
"rules": {}
49+
}
50+
]
51+
}

angular.json

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,15 @@
9898
"src/manifest.webmanifest"
9999
]
100100
}
101+
},
102+
"lint": {
103+
"builder": "@angular-eslint/builder:lint",
104+
"options": {
105+
"lintFilePatterns": [
106+
"src/**/*.ts",
107+
"src/**/*.html"
108+
]
109+
}
101110
}
102111
}
103112
},
@@ -127,6 +136,7 @@
127136
}
128137
},
129138
"cli": {
130-
"analytics": false
139+
"analytics": false,
140+
"defaultCollection": "@angular-eslint/schematics"
131141
}
132142
}

package.json

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,20 @@
3434
},
3535
"devDependencies": {
3636
"@angular-devkit/build-angular": "~13.3.2",
37+
"@angular-eslint/builder": "13.2.0",
38+
"@angular-eslint/eslint-plugin": "13.2.0",
39+
"@angular-eslint/eslint-plugin-template": "13.2.0",
40+
"@angular-eslint/schematics": "13.2.0",
41+
"@angular-eslint/template-parser": "13.2.0",
3742
"@angular/cli": "^13.3.2",
3843
"@angular/compiler-cli": "13.3.2",
3944
"@angular/language-service": "13.3.2",
4045
"@types/jasmine": "~4.0.2",
4146
"@types/jasminewd2": "~2.0.10",
4247
"@types/node": "^17.0.23",
43-
"codelyzer": "^6.0.2",
48+
"@typescript-eslint/eslint-plugin": "5.17.0",
49+
"@typescript-eslint/parser": "5.17.0",
50+
"eslint": "^8.12.0",
4451
"jasmine-core": "~4.1.0",
4552
"jasmine-spec-reporter": "~7.0.0",
4653
"karma": "~6.3.18",
@@ -52,7 +59,6 @@
5259
"pre-commit": "^1.2.2",
5360
"protractor": "~7.0.0",
5461
"ts-node": "~10.7.0",
55-
"tslint": "~6.1.3",
5662
"typescript": "4.6.3"
5763
}
58-
}
64+
}

src/app/auth/auth.component.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
<div class="col-md-6 offset-md-3 col-xs-12">
66
<h1 class="text-xs-center">{{ title }}</h1>
77
<p class="text-xs-center">
8-
<a [routerLink]="['/login']" *ngIf="authType == 'register'">Have an account?</a>
9-
<a [routerLink]="['/register']" *ngIf="authType == 'login'">Need an account?</a>
8+
<a [routerLink]="['/login']" *ngIf="authType === 'register'">Have an account?</a>
9+
<a [routerLink]="['/register']" *ngIf="authType === 'login'">Need an account?</a>
1010
</p>
1111
<app-list-errors [errors]="errors"></app-list-errors>
1212
<form [formGroup]="authForm" (ngSubmit)="submitForm()">
@@ -17,7 +17,7 @@ <h1 class="text-xs-center">{{ title }}</h1>
1717
placeholder="Username"
1818
class="form-control form-control-lg"
1919
type="text"
20-
*ngIf="authType == 'register'" />
20+
*ngIf="authType === 'register'" />
2121
</fieldset>
2222
<fieldset class="form-group">
2323
<input

tslint.json

Lines changed: 0 additions & 141 deletions
This file was deleted.

0 commit comments

Comments
 (0)