Improvements to how new desktop icons are looked for

Author: marticliment

src/UniGetUI/AppOperationHelper.cs

@@ -7,6 +7,7 @@
 using UniGetUI.Core.Tools;
 using UniGetUI.Interface;
 using UniGetUI.Interface.Telemetry;
+using UniGetUI.PackageEngine.Enums;
 using UniGetUI.PackageEngine.Interfaces;
 using UniGetUI.PackageEngine.Managers.CargoManager;
 using UniGetUI.PackageEngine.Managers.PowerShellManager;
@@ -21,6 +22,13 @@ public partial class MainApp
 {
     public static class Operations
     {
+        public static bool AreThereRunningOperations()
+        {
+            return _operationList.Any() &&
+                   _operationList.Where(x => x.Operation.Status is OperationStatus.Running or OperationStatus.InQueue)
+                       .Any();
+        }
+
         public static ObservableCollection<OperationControl> _operationList = new();
 
         public static void Add(AbstractOperation op)

src/UniGetUI/Controls/OperationWidgets/OperationControl.cs

@@ -136,7 +136,7 @@ private void OnOperationFailed(object? sender, EventArgs e)
         ShowErrorToast();
     }
 
-    private void OnOperationFinished(object? sender, EventArgs e)
+    private async void OnOperationFinished(object? sender, EventArgs e)
     {
         // Remove progress notification (if any)
         AppNotificationManager.Default.RemoveByTagAsync(Operation.Metadata.Identifier + "progress");
@@ -159,6 +159,14 @@ private void OnOperationFinished(object? sender, EventArgs e)
         rawOutput.Add("");
         rawOutput.Add("");
         rawOutput.Add("");
+
+        // Handle newly created shortcuts
+        if(Settings.Get("AskToDeleteNewDesktopShortcuts")
+            && !MainApp.Operations.AreThereRunningOperations()
+            && DesktopShortcutsDatabase.GetUnknownShortcuts().Any())
+        {
+            _ = DialogHelper.HandleNewDesktopShortcuts();
+        }
     }
 
     private async void LoadIcon()
@@ -324,13 +332,6 @@ public void Close()
 
         MainApp.Operations._operationList.Remove(this);
         while(AbstractOperation.OperationQueue.Remove(Operation));
-
-        if (MainApp.Operations._operationList.Count == 0
-            && DesktopShortcutsDatabase.GetUnknownShortcuts().Any()
-            && Settings.Get("AskToDeleteNewDesktopShortcuts"))
-        {
-            _ = DialogHelper.HandleNewDesktopShortcuts();
-        }
     }
 
     private string _buttonText;

src/UniGetUI/MainWindow.xaml.cs

@@ -210,8 +210,7 @@ public async void HandleClosingEvent(AppWindow sender, AppWindowClosingEventArgs
             }
             else
             {
-                if (MainApp.Operations._operationList.Any()
-                    && MainApp.Operations._operationList.Where(x => x.Operation.Status is OperationStatus.Running or OperationStatus.InQueue).Any())
+                if (MainApp.Operations.AreThereRunningOperations())
                 {
                     args.Cancel = true;
                     ContentDialog d = new()