Add release draft option and updater fallback

Author: mamoreau-devolutions

.github/workflows/build-release.yml

@@ -7,6 +7,11 @@ on:
         description: 'Release version (e.g. 3.3.7)'
         default: "latest"
         required: true
+      draft-release:
+        description: 'Create the GitHub Release as a draft'
+        required: true
+        type: boolean
+        default: false
       skip-publish:
         description: 'Skip publishing to GitHub Releases'
         required: true
@@ -25,6 +30,7 @@ jobs:
     outputs:
       package-env: ${{ steps.info.outputs.package-env }}
       package-version: ${{ steps.info.outputs.package-version }}
+      draft-release: ${{ steps.info.outputs.draft-release }}
       skip-publish: ${{ steps.info.outputs.skip-publish }}
       dry-run: ${{ steps.info.outputs.dry-run }}
 
@@ -38,6 +44,7 @@ jobs:
         run: |
           $IsProductionBranch = @('main', 'master') -contains '${{ github.ref_name }}'
 
+          try { $DraftRelease = [System.Boolean]::Parse('${{ inputs.draft-release }}') } catch { $DraftRelease = $false }
           try { $SkipPublish = [System.Boolean]::Parse('${{ inputs.skip-publish }}') } catch { $SkipPublish = $false }
           try { $DryRun = [System.Boolean]::Parse('${{ inputs.dry-run }}') } catch { $DryRun = $true }
 
@@ -68,11 +75,13 @@ jobs:
 
           echo "package-env=$PackageEnv" >> $Env:GITHUB_OUTPUT
           echo "package-version=$PackageVersion" >> $Env:GITHUB_OUTPUT
+          echo "draft-release=$($DraftRelease.ToString().ToLower())" >> $Env:GITHUB_OUTPUT
           echo "skip-publish=$($SkipPublish.ToString().ToLower())" >> $Env:GITHUB_OUTPUT
           echo "dry-run=$($DryRun.ToString().ToLower())" >> $Env:GITHUB_OUTPUT
 
           echo "::notice::Environment: $PackageEnv"
           echo "::notice::Version: $PackageVersion"
+          echo "::notice::DraftRelease: $DraftRelease"
           echo "::notice::DryRun: $DryRun"
 
   build:
@@ -316,6 +325,7 @@ jobs:
         working-directory: output
         run: |
           $PackageVersion = '${{ needs.preflight.outputs.package-version }}'
+          $DraftRelease = [System.Boolean]::Parse('${{ needs.preflight.outputs.draft-release }}')
           $DryRun = [System.Boolean]::Parse('${{ needs.preflight.outputs.dry-run }}')
 
           echo "::group::checksums"
@@ -325,15 +335,20 @@ jobs:
           $ReleaseTag = "v$PackageVersion"
           $ReleaseTitle = "UniGetUI v${PackageVersion}"
           $Repository = $Env:GITHUB_REPOSITORY
+          $DraftArg = if ($DraftRelease) { '--draft' } else { $null }
 
           $Files = Get-ChildItem -Path . -Recurse -File | Where-Object {
             $_.Name -eq 'checksums.txt' -or $_.Name -notmatch '^checksums\..+\.txt$'
           }
 
           if ($DryRun) {
             Write-Host "Dry Run: skipping GitHub release creation!"
-            Write-Host "Would create release $ReleaseTag with title '$ReleaseTitle'"
+            Write-Host "Would create release $ReleaseTag with title '$ReleaseTitle' (draft=$DraftRelease)"
             $Files | ForEach-Object { Write-Host "  - $($_.FullName)" }
           } else {
-            & gh release create $ReleaseTag --repo $Repository --title $ReleaseTitle $Files.FullName
+            if ($DraftArg) {
+              & gh release create $ReleaseTag --repo $Repository --title $ReleaseTitle $DraftArg $Files.FullName
+            } else {
+              & gh release create $ReleaseTag --repo $Repository --title $ReleaseTitle $Files.FullName
+            }
           }

src/UniGetUI/AutoUpdater.cs

@@ -98,9 +98,8 @@ public static async Task<bool> CheckAndInstallUpdates(Window window, InfoBar ban
             );
 
             // Check for updates
-            UpdateCandidate updateCandidate = updaterOverrides.UseLegacyGithub
-                ? await CheckForUpdatesFromLegacyGitHub(updaterOverrides)
-                : await CheckForUpdatesFromProductInfo(updaterOverrides);
+            UpdateCandidate updateCandidate = await GetUpdateCandidate(updaterOverrides);
+            Logger.Info($"Updater source '{updateCandidate.SourceName}' returned version {updateCandidate.VersionName} (upgradable={updateCandidate.IsUpgradable})");
 
             if (updateCandidate.IsUpgradable)
             {
@@ -166,6 +165,25 @@ public static async Task<bool> CheckAndInstallUpdates(Window window, InfoBar ban
         }
     }
 
+    private static async Task<UpdateCandidate> GetUpdateCandidate(UpdaterOverrides updaterOverrides)
+    {
+        if (updaterOverrides.UseLegacyGithub)
+        {
+            return await CheckForUpdatesFromLegacyGitHub(updaterOverrides);
+        }
+
+        try
+        {
+            return await CheckForUpdatesFromProductInfo(updaterOverrides);
+        }
+        catch (Exception ex)
+        {
+            Logger.Warn("Productinfo updater source failed. Falling back to legacy GitHub updater source.");
+            Logger.Warn(ex);
+            return await CheckForUpdatesFromLegacyGitHub(updaterOverrides);
+        }
+    }
+
     /// <summary>
     /// Default update source using Devolutions productinfo.json
     /// </summary>

testing/UPDATE-TESTING.md

@@ -2,6 +2,8 @@
 
 This guide validates the new default auto-update flow that reads from `productinfo.json`.
 
+If `productinfo.json` lookup fails for any reason, UniGetUI now falls back to the legacy updater logic that uses the existing version endpoint and GitHub release download URL.
+
 ## Files used
 
 - `testing/productinfo.unigetui.test.json`
@@ -114,15 +116,47 @@ Expected result:
 - Legacy endpoint/GitHub code path is used.
 - Productinfo path is bypassed for that run.
 
-## 7) Optional: disable signer thumbprint check (test-only)
+## 7) Fallback test: broken productinfo with successful legacy fallback
+
+Use one of these methods:
+
+- Point `UpdaterProductInfoUrl` to a missing URL, or
+- Point `UpdaterProductInfoUrl` to a malformed JSON file, or
+- Point `UpdaterProductKey` to a non-existent product.
+
+Example:
+
+```powershell
+Set-ItemProperty -Path 'HKCU:\Software\Devolutions\UniGetUI' -Name 'UpdaterProductInfoUrl' -Value 'http://127.0.0.1:8080/does-not-exist.json'
+Set-ItemProperty -Path 'HKCU:\Software\Devolutions\UniGetUI' -Name 'UpdaterUseLegacyGithub' -Type DWord -Value 0
+```
+
+Expected result:
+
+- Productinfo check fails.
+- UniGetUI logs that it is falling back to the legacy GitHub updater source.
+- Legacy updater path is used automatically.
+- If the legacy source has a newer version, the update flow continues normally.
+
+## 8) Fallback test: both sources fail
+
+Use a broken productinfo override and also make the legacy source unavailable in your test environment.
+
+Expected result:
+
+- Productinfo check fails first.
+- UniGetUI attempts the legacy updater path.
+- The updater shows the existing terminal error because neither source succeeded.
+
+## 9) Optional: disable signer thumbprint check (test-only)
 
 Use this only if your local installer is unsigned or signed with a non-Devolutions certificate.
 
 ```powershell
 Set-ItemProperty -Path 'HKCU:\Software\Devolutions\UniGetUI' -Name 'UpdaterSkipSignerThumbprintCheck' -Type DWord -Value 1
 ```
 
-## 8) Cleanup after testing
+## 10) Cleanup after testing
 
 Reset to default production behavior: