hooks/ponytail-config.js: 'review' in VALID_MODES but not RUNTIME_MODES — config accepts it but silently falls back to 'full'

[nanaubusiness]

In hooks/ponytail-config.js:

const VALID_MODES = ['off', 'lite', 'full', 'ultra', 'review'];
const RUNTIME_MODES = ['off', 'lite', 'full', 'ultra'];

Setting PONYTAIL_DEFAULT_MODE=review passes validation, but normalizeMode('review') returns null (since 'review' is not in RUNTIME_MODES), causing fallback to 'full'. A user who configures 'review' as default would never know they're actually running in 'full' mode.

[nanaubusiness]

Already fixed in PR #395.

[nanaubusiness]

Reopening — corresponding PR is under review.

[DietrichGebert]

Closing as invalid. The premise is the problem: review is not an always-on runtime mode, it is a command-triggered task mode (run via /ponytail-review for a single over-engineering pass, then you return to your level). RUNTIME_MODES lists the always-on intensity levels a user selects (lite/full/ultra/off) and deliberately excludes review; VALID_MODES additionally includes review only so the command-set value persists and round-trips. So this is not a missing entry to add.

(For the record, setting PONYTAIL_DEFAULT_MODE=review also does not fall back to full — it emits review instructions — but that is beside the main point.)