Skip to content

recordVerification's conflict handling only compares result, ignoring changes to evidenceHash or disputed on a repeat call #1440

Description

@1nonlypiece

recordVerification in src/services/verifiers.ts (lines 207-238) checks for an existing (verifier_user_id, target_id) row and, if found with the same result, silently returns the existing row (return mapVerificationRow(existing), line 224) without checking whether evidenceHash or disputed differ from what's now being submitted — only a genuinely different result triggers the VerificationConflictError. A verifier who resubmits the same approve/reject decision but with different evidence (e.g. correcting a wrong evidence hash) has their new evidence silently discarded in favor of the original row, with no error or indication that the update was ignored, since the function returns success (the pre-existing record) rather than surfacing that the resubmission had no effect.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions