Change jp to ja?

[SachaG]

I got it wrong when I created the Japanese repo and used the wrong language code.

Do you think I should change jp to ja everywhere (repo name, domain, etc.) or is it just not worth it?

It would probably take me an hour or so altogether, so it's not like it's a huge deal. Just wondering :)

[ento]

+1 In my eyes, it's worth it. It's politically and standard-wisely correct and also earlier the better, because less people will be affected by the change.

[louixs]

+1 here too. As you might know jp is technically a country code. I also support ento's point about changing it as early as possible.

[SachaG]

Done. I might have broken a few things, I guess we'll find out soon enough :)

[ento]

It looks like the "Translations" page needs to be updated too.

Also there are some lingering jps in:

• strings
• submodule directory name

[SachaG]

I'll take care of the translations page. I think the other ones are fixed, although it's still a bit mysterious to me how exactly git submodules work…

[ento]

Confirmed the other ones are fixed 👍