Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SA1514: Do not report when documenting types declared in the global namespace #3863

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix SA1514: Do not report when documenting types declared in the global namespace #3863

wants to merge 3 commits into from

Conversation

MattFromRVA
Copy link
Contributor

Fixes #3849

@codecov Codecov
Copy link

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.46%. Comparing base (51c772e) to head (cd99e2f).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #3863    +/-   ##
========================================
  Coverage   97.45%   97.46%            
========================================
  Files         926      926            
  Lines      110202   110394   +192     
  Branches     3312     3316     +4     
========================================
+ Hits       107398   107590   +192     
  Misses       1837     1837            
  Partials      967      967

@MattFromRVA MattFromRVA marked this pull request as draft July 2, 2024 02:05
@MattFromRVA MattFromRVA marked this pull request as ready for review July 2, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornhellander bjornhellander bjornhellander approved these changes

@sharwell sharwell Awaiting requested review from sharwell

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SA1514 is falsely reported when documenting types declared in the global namespace
3 participants
@MattFromRVA @sharwell @bjornhellander