Update SA1135UsingDirectivesMustBeQualified to not crash on a UsingDirectiveSyntax without a Name #3883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3883 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 926 927 +1
Lines 110237 110265 +28
Branches 3315 3316 +1
=======================================
+ Hits 107433 107461 +28
Misses 1837 1837
Partials 967 967 |
…rectiveSyntax without a Name (c# 12's "alias any type") DotNetAnalyzers#3882
bjornhellander
force-pushed
the
feature/sa1135-using-type-alias
branch
from
d4b0351
to
ea5e0d9
Compare
|
So far, this pull request only prevents the exception. I assume that the analyzer should also be updated to check all the new types of aliases that can be created now. I have started looking at that as well, but it seems to be less trivial. Would it be ok to save that for another pull request if I create a separate issue for that, @sharwell? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3882.