DYN-7152 Update build dynamo workflow (#15410)

Author: avidit

.github/workflows/build_dynamo_all.yml

@@ -1,5 +1,4 @@
-# Build DynamoAll.sln with .NET 8.0
-name: Build DynamoAll.sln net8.0
+name: Build DynamoAll.sln
 
 on:
   push:
@@ -8,7 +7,8 @@ on:
   pull_request:
 
 jobs:
-  build:
+  build_and_analyze:
+    name: Build and Analyze
     runs-on: windows-latest
     steps:
       - name: Checkout Dynamo Repo
@@ -29,8 +29,7 @@ jobs:
           dotnet restore ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release --runtime=win-x64
       - name: Build Dynamo with MSBuild for Windows
         run: |
-          Write-Output "***Continue with the build, Good luck developer!***"
-          msbuild ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release
+          msbuild ${{ github.workspace }}\Dynamo\src\Dynamo.All.sln /p:Configuration=Release /warnAsError:RS0016,RS0017 /p:PublicApiAnalyzers=true
       - name: Look for DynamoCLI.exe
         run: |
           Write-Output "***Locating DynamoCLI.exe!***"

.github/workflows/dynamo_api_break.yml

@@ -3,7 +3,7 @@ name: UI Smoke Tests
 on:
   workflow_run:
     workflows:
-      - Build DynamoAll.sln net8.0
+      - Build DynamoAll.sln
     types:
       - completed
 
@@ -13,6 +13,7 @@ env:
   WORKFLOW_RUN_ID: ${{ github.event.workflow_run.id }}
   WORKFLOW_RUN_NAME: ${{ github.event.workflow_run.name }}
   WORKFLOW_RUN_HTML_URL: ${{ github.event.workflow_run.html_url }}
+  CHECK_NAME: UI Smoke Tests
 
 jobs:
   ui_smoke_tests:
@@ -49,7 +50,6 @@ jobs:
       - name: Set Run Details
         run: |
           "PR_NUMBER=$(Get-Content -Path ${{ github.workspace }}\pr\pr_number.txt)" | Out-File -FilePath $env:GITHUB_ENV -Append
-          "CHECK_NAME=$("UI Smoke Tests", $($env:WORKFLOW_RUN_NAME -Split " ")[-1] -Join " - ")" | Out-File -FilePath $env:GITHUB_ENV -Append
       - name: Run Tests
         shell: cmd
         run: .\utils\run_tests.bat ${{ secrets.SMARTBEAR_ACCESS_KEY }} Dynamo\Dynamo.pjs DynamoSandbox SmokeTests ${{ github.workspace }}\build
@@ -84,7 +84,7 @@ jobs:
         id: create_comment
         run: |
           $pr_comment=@"
-          ## UI Smoke Tests
+          ## $env:CHECK_NAME
           Test: **${{ steps.test_report.outputs.conclusion }}**. ${{ steps.test_report.outputs.passed }} passed, ${{ steps.test_report.outputs.failed }} failed.
           [TestComplete Test Result]($(Get-Content -Path ${{ github.workspace }}\reports\result.txt))
           Workflow Run: [${{ github.workflow }}](${{ format('{0}/{1}/actions/runs/{2}', github.server_url, github.repository, github.run_id) }})
@@ -98,7 +98,7 @@ jobs:
         with:
           issue-number: ${{ env.PR_NUMBER }}
           comment-author: github-actions[bot]
-          body-includes: UI Smoke Tests
+          body-includes: ${{ env.CHECK_NAME }}
           direction: last
       - name: Create comment
         if: env.PR_NUMBER != '' && steps.find_comment.outputs.comment-id == ''

.github/workflows/ui_smoke_tests.yml

@@ -1,7 +1,7 @@
 # Dynamo
 
-[![Build DynamoAll.sln net8.0](https://github.com/DynamoDS/Dynamo/actions/workflows/build_dynamo_all.yml/badge.svg)](https://github.com/DynamoDS/Dynamo/actions/workflows/build_dynamo_all.yml)
-[![Build DynamoCore.sln](https://github.com/DynamoDS/Dynamo/actions/workflows/build_dynamo_core_windows.yml/badge.svg)](https://github.com/DynamoDS/Dynamo/actions/workflows/build_dynamo_core.yml)
+[![Build DynamoAll.sln](https://github.com/DynamoDS/Dynamo/actions/workflows/build_dynamo_all.yml/badge.svg)](https://github.com/DynamoDS/Dynamo/actions/workflows/build_dynamo_all.yml)
+[![Build DynamoCore.sln](https://github.com/DynamoDS/Dynamo/actions/workflows/build_dynamo_core.yml/badge.svg)](https://github.com/DynamoDS/Dynamo/actions/workflows/build_dynamo_core.yml)
 
 [![DynamoCoreRuntime](https://img.shields.io/github/v/release/DynamoDS/Dynamo?logo=github&label=DynamoCoreRuntime)](https://github.com/DynamoDS/Dynamo/releases/latest)
 [![Nuget](https://img.shields.io/nuget/v/DynamoVisualProgramming.Core?logo=nuget)](https://www.nuget.org/packages/DynamoVisualProgramming.Core)