Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase onto v0.20.2 #23

Closed
xylar opened this issue Oct 4, 2023 · 3 comments
Closed

Rebase onto v0.20.2 #23

xylar opened this issue Oct 4, 2023 · 3 comments
Assignees

Comments

@xylar
Copy link
Collaborator

xylar commented Oct 4, 2023

@ikalash, there was a new release of spack today:
https://github.com/spack/spack/releases/tag/v0.20.2
It looks like we will have an easy time with the rebase again, as you can see in my test branch here:
https://github.com/xylar/spack/tree/rebase-onto-0.20.2

I'd like to force-push the rebase but we should decide first if we want #22 to go in before or after that. I'm fine either way because I don't actually use develop directly in my own workflows.

@xylar
Copy link
Collaborator Author

xylar commented Oct 5, 2023

@ikalash, I just remade my branch by rebasing the latest develop on to the v0.20.2 tag. Could you give it a try? If you approve, I'll force-push to develop.

@ikalash
Copy link

ikalash commented Oct 6, 2023

I tested this yesterday. I think it is OK to merge. There were failures in my nightly spack build but that was due to changes in Trilinos, and they are showing up in non-spack builds too. An issue has been opened.

@xylar
Copy link
Collaborator Author

xylar commented Oct 7, 2023

Thanks! I just pushed my rebase branch to develop.

@xylar xylar closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants