Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Sort out the colour updates for the measurement station lines #257

Open
rstrange-scottlogic opened this issue Jul 26, 2024 · 1 comment
Assignees

Comments

@rstrange-scottlogic
Copy link
Collaborator

rstrange-scottlogic commented Jul 26, 2024

We have some code that is responsible for updating the colours of the lines in the measurement charts. In the SingleCity.tsx page we have a bunch of code setting site colorus, which calls updateColors() etc.

When running locally this code appears to work fine, and you can see the colours changing on the loaded graphs (easier to see with more stations, i.e. Tokyo). The lines are made darker and more prominent as well as changing colour.

On the deployed version we do not see this, and the default eCharts colours are still shown. We also receive a JS error in the browser console, which may be related.

We should do either

  1. fix the error so the colour change also happens on the deployed version,
  2. delete the code and leave the eCharts colours as they are on our deployed version too.

We will fix!

Hopefully whichever we choose will sort out the error occurring on the browser (seen in Chrome at least)

Example of the issue :

Image

Ideas to test:

  • check prod issue in screenshot is resolved
  • automation for one city site - cryptographically hash station name, small graph with one station, assert colour or if not possible, screenshot test would work
@rstrange-scottlogic rstrange-scottlogic changed the title Sort out the colour updates for the measurement station lines BUG Sort out the colour updates for the measurement station lines Jul 29, 2024
@Ben-EJ Ben-EJ self-assigned this Aug 1, 2024
Ben-EJ added a commit that referenced this issue Aug 2, 2024
Ben-EJ added a commit that referenced this issue Aug 2, 2024
@Ben-EJ Ben-EJ removed their assignment Aug 2, 2024
@lincent lincent self-assigned this Aug 6, 2024
@lincent
Copy link
Collaborator

lincent commented Aug 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants