Skip to content

Commit 28670f6

Browse files
authored
Merge pull request #866 from bedroge/SciPy-bundle-2023.07-bug-fix
{2023.06}[2023a] Rebuild SciPy-bundle 2023.07 with additional patches
2 parents 1ff54de + bc7ab49 commit 28670f6

File tree

3 files changed

+31
-4
lines changed

3 files changed

+31
-4
lines changed

EESSI-install-software.sh

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,15 @@ else
336336
if [ -f ${easystack_file} ]; then
337337
echo_green "Feeding easystack file ${easystack_file} to EasyBuild..."
338338

339-
${EB} --easystack ${easystack_file} --robot
339+
if [[ ${easystack_file} == *"/rebuilds/"* ]]; then
340+
# the removal script should have removed the original directory and created a new and empty one
341+
# to work around permission issues:
342+
# https://github.com/EESSI/software-layer/issues/556
343+
echo_yellow "This is a rebuild, so using --try-amend=keeppreviousinstall=True to reuse the already created directory"
344+
${EB} --easystack ${easystack_file} --robot --try-amend=keeppreviousinstall=True
345+
else
346+
${EB} --easystack ${easystack_file} --robot
347+
fi
340348
ec=$?
341349

342350
# copy EasyBuild log file if EasyBuild exited with an error

EESSI-remove-software.sh

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,13 +125,18 @@ if [ $EUID -eq 0 ]; then
125125
# Two dirname invocations, so returns e.g. /cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/amd/zen2
126126
app_installprefix=$(dirname $(dirname ${app_modulepath}))
127127
app_dir=${app_installprefix}/software/${app}
128+
app_subdirs=$(find ${app_dir} -mindepth 1 -maxdepth 1 -type d)
128129
app_module=${app_installprefix}/modules/all/${app}.lua
129130
echo_yellow "Removing ${app_dir} and ${app_module}..."
130131
rm -rf ${app_dir}
131132
rm -rf ${app_module}
132-
# recreate some directory to work around permission denied
133-
# issues when rebuilding the package
134-
mkdir -p ${app_dir}/easybuild
133+
# recreate the installation directories and first-level subdirectories to work around permission denied
134+
# issues when rebuilding the package (see https://github.com/EESSI/software-layer/issues/556)
135+
echo_yellow "Recreating an empty ${app_dir}..."
136+
mkdir -p ${app_dir}
137+
for app_subdir in ${app_subdirs}; do
138+
mkdir -p ${app_subdir}
139+
done
135140
done
136141
else
137142
fatal_error "Easystack file ${easystack_file} not found!"
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
# 2025.01.21
2+
# While adding support for Intel Sapphire Rapids, additional patches applied to the
3+
# original easyconfig were required to successfully build SciPy-bundle 2023.07.
4+
# In order to keep the stack consistent across the different CPUs,
5+
# a rebuild is done for all CPU targets with this updated easyconfig.
6+
# See:
7+
# - https://github.com/easybuilders/easybuild-easyconfigs/pull/19419
8+
# - https://github.com/easybuilders/easybuild-easyconfigs/pull/20817
9+
# - https://github.com/easybuilders/easybuild-easyconfigs/pull/21693
10+
easyconfigs:
11+
- SciPy-bundle-2023.07-gfbf-2023a.eb:
12+
options:
13+
# see https://github.com/easybuilders/easybuild-easyconfigs/pull/21693
14+
from-commit: 7c5144d2c1a061cd9f08b5901970b7f6ec5eb5c0

0 commit comments

Comments
 (0)