Skip to content

Commit

Permalink
v2.0.0 happy new year 2025
Browse files Browse the repository at this point in the history
Issue on split screen view, popup view and landscape view
#47

Fatal Exception: NSInvalidArgumentException on iOS
#48
  • Loading branch information
EMI-INDO committed Dec 30, 2024
1 parent 6e3c1e6 commit 018c767
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 17 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "emi-indo-cordova-plugin-admob",
"version": "1.9.9",
"version": "2.0.0",
"description": "Cordova/Quasar/Capacitor Plugin Admob Android IOS",
"cordova": {
"id": "emi-indo-cordova-plugin-admob",
Expand Down
9 changes: 8 additions & 1 deletion plugin.xml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
xmlns:android="http://schemas.android.com/apk/res/android"
id="emi-indo-cordova-plugin-admob" version="1.9.9">
id="emi-indo-cordova-plugin-admob" version="2.0.0">

<name>emiAdmobPlugin</name>
<description>Cordova/Quasar/Capacitor Plugin Admob Android IOS</description>
Expand Down Expand Up @@ -74,6 +74,13 @@
<preference name="ANDROID_X" default="1.2.0" />
<framework src="androidx.preference:preference:$ANDROID_X" />

<preference name="MULTI_WINDOW" default="false" />

<edit-config file="AndroidManifest.xml" mode="merge" target="/manifest/application/activity[@android:name='MainActivity']">
<activity android:resizeableActivity="$MULTI_WINDOW" />
</edit-config>



<config-file parent="/*" target="AndroidManifest.xml" />
<source-file src="src/android/emiAdmobPlugin.kt" target-dir="app/src/main/kotlin/emi/indo/cordova/plugin/admob" />
Expand Down
33 changes: 18 additions & 15 deletions src/ios/emiAdmobPlugin.m
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,7 @@ - (void)orientationDidChange:(NSNotification *)notification {
}

[self setAdRequest];


self.bannerViewLayout = [[UIView alloc] initWithFrame:CGRectZero];
self.bannerViewLayout.translatesAutoresizingMaskIntoConstraints = NO;
Expand Down Expand Up @@ -809,11 +810,12 @@ - (void)loadAppOpenAd:(CDVInvokedUrlCommand *)command {
NSString *adUnitId = strongSelf.appOpenAd.adUnitID;

NSDictionary *data = @{
@"value": adValue,
@"currencyCode": currencyCode,
@"value": adValue ?: [NSNull null],
@"currencyCode": currencyCode ?: @"",
@"precision": @(precision),
@"adUnitId": adUnitId
@"adUnitId": adUnitId ?: @""
};

NSData *jsonData = [NSJSONSerialization dataWithJSONObject:data options:0 error:nil];
NSString *jsonString = [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding];

Expand Down Expand Up @@ -937,11 +939,12 @@ - (void)loadInterstitialAd:(CDVInvokedUrlCommand *)command {
NSString *adUnitId = strongSelf.interstitial.adUnitID;

NSDictionary *data = @{
@"value": adValue,
@"currencyCode": currencyCode,
@"value": adValue ?: [NSNull null],
@"currencyCode": currencyCode ?: @"",
@"precision": @(precision),
@"adUnitId": adUnitId
@"adUnitId": adUnitId ?: @""
};

NSData *jsonData = [NSJSONSerialization dataWithJSONObject:data options:0 error:nil];
NSString *jsonString = [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding];

Expand Down Expand Up @@ -1072,10 +1075,10 @@ - (void)loadRewardedInterstitialAd:(CDVInvokedUrlCommand *)command {
NSString *adUnitId = strongSelf.rewardedInterstitialAd.adUnitID;

NSDictionary *data = @{
@"value": adValue,
@"currencyCode": currencyCode,
@"value": adValue ?: [NSNull null],
@"currencyCode": currencyCode ?: @"",
@"precision": @(precision),
@"adUnitId": adUnitId
@"adUnitId": adUnitId ?: @""
};
NSData *jsonData = [NSJSONSerialization dataWithJSONObject:data options:0 error:nil];
NSString *jsonString = [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding];
Expand Down Expand Up @@ -1229,10 +1232,10 @@ - (void)loadRewardedAd:(CDVInvokedUrlCommand *)command {
NSString *adUnitId = strongSelf.rewardedAd.adUnitID;

NSDictionary *data = @{
@"value": adValue,
@"currencyCode": currencyCode,
@"value": adValue ?: [NSNull null],
@"currencyCode": currencyCode ?: @"",
@"precision": @(precision),
@"adUnitId": adUnitId
@"adUnitId": adUnitId ?: @""
};
NSData *jsonData = [NSJSONSerialization dataWithJSONObject:data options:0 error:nil];
NSString *jsonString = [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding];
Expand Down Expand Up @@ -1480,10 +1483,10 @@ - (void)bannerViewDidReceiveAd:(GADBannerView *)bannerView {
NSString *adUnitId = strongSelf.bannerView.adUnitID;

NSDictionary *data = @{
@"value": adValue,
@"currencyCode": currencyCode,
@"value": adValue ?: [NSNull null],
@"currencyCode": currencyCode ?: @"",
@"precision": @(precision),
@"adUnitId": adUnitId
@"adUnitId": adUnitId ?: @""
};
NSData *jsonData = [NSJSONSerialization dataWithJSONObject:data options:0 error:nil];
NSString *jsonString = [[NSString alloc] initWithData:jsonData encoding:NSUTF8StringEncoding];
Expand Down

0 comments on commit 018c767

Please sign in to comment.