Hide enchantment cracking

Author: Earthcomputer

README.txt

@@ -78,49 +78,10 @@ Common problems with setup:
 /csimgen (deprecated) - simulated the generation of a world generator.
 /ctemprule - get and set variables which affect the workings of clientcommands. TempRules reset
              when you log out of a world.
-/cenchant - manipulate the XP seed so that you can get the specified enchantments in an
-            enchantment table. This only works if the enchantment seed is cracked (see below).
-            First you specify the type of item you want to enchant, and then zero or more
-            enchantment specifications. There are two types of enchantment specifications:
-               `with` - This enchantment should be included in the enchantments on the item.
-               `without` - This enchantment should not be included in the enchantments on
-                           the item.
-            In addition to the enchantment, you also specify the level of the enchantment
-            you would like. This level can either be an exact number, or a range in the
-            format min..max (e.g. `1..5`).
-            Once you run the command, the enchantment cracker may automatically throw items
-            onto the ground beneath you. Do not look anywhere else while this is happening,
-            as you may not be able to pick the items back up again. Once this is done,
-            follow the instructions the command gives you.
-            Examples:
-               `/cenchant diamond_sword with looting 3 without smite 1..5 without bane_of_arthropods 1..5`
-               `/cenchant fishing_rod with lure 3 with luck_of_the_sea 3`
 /ctime - queries or changes the time client-side. All subcommands except `mock` and `unmock`
          only query the time. Using `/ctime mock <daytime> [doDaylightCycle]` starts mocking
          the time, and `/ctime unmock` stops mocking the time. Mocking the time means
          making it appear to be a certain time on the client-side only, while the server-
          side time (which is the time that matters for mob spawning etc.) is unaffected.
          `/ctime mock` is intended for builders to inspect their builds at different times of
          day.
-
-===== ENCHANTING PREDICTION =====
-WARNING: enchanting prediction is very cheaty and could get you banned from a server if an
-         operator finds out. However, given its client-side-only nature it's very difficult
-         to detect. There is also a chance it may be patched.
-
-Enchanting prediction can be used to see all items you would get on an enchantment in an
-enchantment table before you actually enchant the item. To use enchanting prediction,
-you must follow the following steps at the start of every enchanting session:
-   1) run `/ctemprule set enchantingPrediction true`
-   2) waste your first enchantment (enchant a cheap item)
-   3) place another cheap item into the enchantment table (don't enchant it)
-   4) block some more bookshelves with a torch
-   5) repeat steps 3 and 4 until you're in state CRACKED_ENCH_SEED
-   6) enchant the item (you can remove the torches now)
-   7) repeat steps 3-6 once or twice more, until you're in state CRACKED
-   8) there are certain common actions which will reset the process; clientcommands will
-      notify you when this happens. You just have to avoid doing these actions.
-
-Once you are in state CRACKED, you will be able to see all enchantments before you enchant
-the item. You will stay in state CRACKED for the duration of the enchantment session unless
-you do one of the actions from step 8. If this happens, you have to start from step 2 again.

src/main/java/net/earthcomputer/clientcommands/TempRules.java

@@ -20,20 +20,16 @@ public class TempRules {
 	private static Map<String, Rule<?>> rules = new HashMap<>();
 
 	public static final Rule<Boolean> ENCHANTING_PREDICTION = registerRule("enchantingPrediction", DataType.BOOLEAN,
-			Boolean.FALSE);
+			Boolean.FALSE).setHidden();
 	public static final Rule<EnchantmentCracker.EnumCrackState> ENCHANTING_CRACK_STATE = registerRule(
 			"enchantingCrackState", EnumDataType.of(EnchantmentCracker.EnumCrackState.class),
-			EnchantmentCracker.EnumCrackState.UNCRACKED);
+			EnchantmentCracker.EnumCrackState.UNCRACKED).setReadOnly().setHidden();
 	public static final Rule<Double> BLOCK_REACH_DISTANCE = registerRule("blockReachDistance", DataType.DOUBLE.min(0),
 			5.0);
 	public static final Rule<Boolean> TOOL_BREAK_PROTECTION = registerRule("toolBreakProtection", DataType.BOOLEAN,
 			Boolean.FALSE);
-	public static final Rule<Boolean> MOCKING_TIME = registerRule("mockingTime", DataType.BOOLEAN, Boolean.FALSE);
-
-	static {
-		ENCHANTING_CRACK_STATE.setReadOnly();
-		MOCKING_TIME.setReadOnly();
-	}
+	public static final Rule<Boolean> MOCKING_TIME = registerRule("mockingTime", DataType.BOOLEAN, Boolean.FALSE)
+			.setReadOnly();
 
 	public static boolean hasRule(String name) {
 		return rules.containsKey(name);
@@ -67,6 +63,7 @@ public static class Rule<T> {
 		private T defaultValue;
 		private T value;
 		private boolean readOnly = false;
+		private boolean hidden = false;
 		private List<Consumer<ValueChangeEvent<T>>> listeners = new ArrayList<>();
 
 		private Rule(String name, DataType<T> dataType, T defaultValue) {
@@ -111,8 +108,18 @@ public boolean isReadOnly() {
 			return readOnly;
 		}
 
-		public void setReadOnly() {
+		public Rule<T> setReadOnly() {
 			readOnly = true;
+			return this;
+		}
+
+		public boolean isHidden() {
+			return hidden;
+		}
+
+		public Rule<T> setHidden() {
+			hidden = true;
+			return this;
 		}
 
 		public void addValueChangeListener(Consumer<ValueChangeEvent<T>> listener) {

src/main/java/net/earthcomputer/clientcommands/command/CommandCEnchant.java

@@ -8,6 +8,7 @@
 
 import net.earthcomputer.clientcommands.EnchantmentCracker;
 import net.earthcomputer.clientcommands.EnchantmentCracker.EnchantManipulationStatus;
+import net.earthcomputer.clientcommands.TempRules;
 import net.earthcomputer.clientcommands.task.TaskManager;
 import net.minecraft.command.CommandException;
 import net.minecraft.command.ICommandSender;
@@ -34,6 +35,11 @@ public String getUsage(ICommandSender sender) {
 		return "commands.cenchant.usage";
 	}
 
+	@Override
+	public boolean checkPermission(MinecraftServer server, ICommandSender sender) {
+		return TempRules.ENCHANTING_CRACK_STATE.getValue() == EnchantmentCracker.EnumCrackState.CRACKED;
+	}
+
 	@Override
 	public void execute(MinecraftServer server, ICommandSender sender, String[] args) throws CommandException {
 		if (args.length < 4) {

src/main/java/net/earthcomputer/clientcommands/command/CommandTempRule.java

@@ -98,11 +98,14 @@ public List<String> getTabCompletions(MinecraftServer server, ICommandSender sen
 			return getListOfStringsMatchingLastWord(args, "get", "set", "reset", "list");
 		} else if (args.length == 2 && !"list".equals(args[0])) {
 			if ("get".equals(args[0])) {
-				return getListOfStringsMatchingLastWord(args, TempRules.getRuleNames());
-			} else {
 				return getListOfStringsMatchingLastWord(args,
-						TempRules.getRules().stream().filter(rule -> !rule.isReadOnly()).map(TempRules.Rule::getName)
+						TempRules.getRules().stream().filter(rule -> !rule.isHidden()).map(TempRules.Rule::getName)
 								.sorted().collect(Collectors.toList()));
+			} else {
+				return getListOfStringsMatchingLastWord(args,
+						TempRules.getRules().stream().filter(rule -> !rule.isReadOnly())
+								.filter(rule -> !rule.isHidden()).map(TempRules.Rule::getName).sorted()
+								.collect(Collectors.toList()));
 			}
 		} else if (args.length == 3 && "set".equals(args[0]) && TempRules.hasRule(args[1])) {
 			TempRules.Rule<?> rule = TempRules.getRule(args[1]);