[Draft] Alternative rqa trend implementation respecting actual time stamps #73
Closed
meggart wants to merge 3 commits into
Closed
[Draft] Alternative rqa trend implementation respecting actual time stamps #73meggart wants to merge 3 commits into
meggart wants to merge 3 commits into
Conversation
Collaborator
|
As mentioned at today's meeting. It might be worthwhile to test the tile wide performance with this branch and teat it against the faster implementation |
Collaborator
|
I am wondering whether we could improve the speed of this implementation by precomputing the x mean and x squared mean, because this should be the same for all pixels. |
Collaborator
|
I am closing this for now, because we decided to not go forward with it at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to collect the results of our experiments with @felixcremer. This is mostly for documentation purposes and does not necessarily need to be merged since the resulting algorithm is 20x slower than the current version.