have operator support multiple values for one-to-many relations #8708

many-to-many always worked and keep working, but one-to-many were broken SQL

Author: PowerKiKi

src/Definition/Operator/HaveOperatorType.php

@@ -5,6 +5,7 @@
 namespace GraphQL\Doctrine\Definition\Operator;
 
 use Doctrine\ORM\Mapping\ClassMetadata;
+use Doctrine\ORM\Mapping\ClassMetadataInfo;
 use Doctrine\ORM\QueryBuilder;
 use GraphQL\Doctrine\Factory\UniqueNameFactory;
 use GraphQL\Type\Definition\LeafType;
@@ -38,10 +39,29 @@ protected function getSingleValuedDqlCondition(UniqueNameFactory $uniqueNameFact
 
     protected function getCollectionValuedDqlCondition(UniqueNameFactory $uniqueNameFactory, ClassMetadata $metadata, QueryBuilder $queryBuilder, string $alias, string $field, array $args): ?string
     {
+        $association = $metadata->associationMappings[$field];
         $values = $uniqueNameFactory->createParameterName();
         $queryBuilder->setParameter($values, $args['values']);
         $not = $args['not'] ? 'NOT ' : '';
 
+        // For one-to-many we cannot rely on MEMBER OF, because it does not support multiple values (in SQL it always
+        // use `=`, and not `IN()`). So we simulate an approximation of MEMBER OF that support multiple values. But it
+        // does **not** support composite identifiers. And that is fine because it is an official limitation of this
+        // library anyway.
+        if ($association['type'] === ClassMetadataInfo::ONE_TO_MANY) {
+            $id = $metadata->identifier[0];
+
+            $otherClassName = $association['targetEntity'];
+            $otherAlias = $uniqueNameFactory->createAliasName($otherClassName);
+            $otherField = $association['mappedBy'];
+            $otherMetadata = $queryBuilder->getEntityManager()->getClassMetadata($otherClassName);
+            $otherId = $otherMetadata->identifier[0];
+
+            $result = $not . "EXISTS (SELECT 1 FROM $otherClassName $otherAlias WHERE $otherAlias.$otherField = $alias.$id AND $otherAlias.$otherId IN (:$values))";
+
+            return $result;
+        }
+
         return ':' . $values . ' ' . $not . 'MEMBER OF ' . $alias . '.' . $field;
     }
 }

tests/Blog/Model/User.php

@@ -52,6 +52,13 @@ final class User extends AbstractModel
      */
     private $posts;
 
+    /**
+     * @var \Doctrine\Common\Collections\Collection
+     *
+     * @ORM\ManyToMany(targetEntity="GraphQLTests\Doctrine\Blog\Model\Post")
+     */
+    private $favoritePosts;
+
     /**
      * @var null|User
      *

tests/Definition/Operator/OperatorsTest.php

@@ -89,7 +89,7 @@ public function providerOperator(): array
                 'posts',
             ],
             [
-                ':filter1 MEMBER OF alias.posts',
+                'EXISTS (SELECT 1 FROM GraphQLTests\Doctrine\Blog\Model\Post post1 WHERE post1.user = alias.id AND post1.id IN (:filter1))',
                 HaveOperatorType::class,
                 [
                     'values' => [123, 456],
@@ -98,7 +98,7 @@ public function providerOperator(): array
                 'posts',
             ],
             [
-                ':filter1 NOT MEMBER OF alias.posts',
+                'NOT EXISTS (SELECT 1 FROM GraphQLTests\Doctrine\Blog\Model\Post post1 WHERE post1.user = alias.id AND post1.id IN (:filter1))',
                 HaveOperatorType::class,
                 [
                     'values' => [123, 456],
@@ -130,6 +130,24 @@ public function providerOperator(): array
                 ],
                 'manager',
             ],
+            [
+                ':filter1 MEMBER OF alias.favoritePosts',
+                HaveOperatorType::class,
+                [
+                    'values' => [123, 456],
+                    'not' => false,
+                ],
+                'favoritePosts',
+            ],
+            [
+                ':filter1 NOT MEMBER OF alias.favoritePosts',
+                HaveOperatorType::class,
+                [
+                    'values' => [123, 456],
+                    'not' => true,
+                ],
+                'favoritePosts',
+            ],
             [
                 null,
                 EmptyOperatorType::class,

tests/data/PostFilter.graphqls

@@ -561,6 +561,7 @@ input UserFilterGroupCondition {
   isAdministrator: UserFilterGroupConditionIsAdministrator
   id: UserFilterGroupConditionId
   posts: UserFilterGroupConditionPosts
+  favoritePosts: UserFilterGroupConditionFavoritePosts
   manager: UserFilterGroupConditionManager
 }
 
@@ -592,6 +593,12 @@ input UserFilterGroupConditionEmail {
   group: GroupOperatorString
 }
 
+"""Type to specify a condition on a specific field"""
+input UserFilterGroupConditionFavoritePosts {
+  have: HaveOperatorID
+  empty: EmptyOperatorID
+}
+
 """Type to specify a condition on a specific field"""
 input UserFilterGroupConditionId {
   like: LikeOperatorID
@@ -659,6 +666,7 @@ input UserFilterGroupConditionPosts {
 """Type to specify join tables in a filter"""
 input UserFilterGroupJoin {
   posts: JoinOnPost
+  favoritePosts: JoinOnPost
   manager: JoinOnUser
 }