2.0.0-beta.23 (#96)

* [MM] Invert scroll monitor offset (#96)

Author: MatthewCMoya

docs/README.md

@@ -42,7 +42,7 @@ const homepageAdPage = new AdJS.Page(AdJS.Networks.DFP, {
       desktop: { from: 1200, to: Infinity },
     },
     refreshRateInSeconds: 1000,
-    offset: -100,
+    offset: 100,
     targeting: { example: 'true' },
   }
 });
@@ -84,7 +84,7 @@ const el = document.findElementById('example');
 
 const bannerAd = new homepageAdPage.Ad(el, {
   path: '/1234/example/homepage',
-  offset: -10,
+  offset: 10,
 });
 ```
 

docs/lazy-load-plugin.md

@@ -99,7 +99,7 @@ const ad = new page.createAd(el, {
     AutoRender
   ],
 
-  renderOffset: -100,
+  renderOffset: 100,
   autoLoad: true,
 });
 ```

docs/spa.md

@@ -58,7 +58,7 @@ const homepageAdPage = new AdJS.Page(DFPNetwork, {
 });
 
 const bannerAd = new homepageAdPage.Ad('.bannerAd', {
-  offset: -10,
+  offset: 10,
   modules: [Banner],
   fixBannerInMs: 100,
 });
@@ -67,7 +67,7 @@ const boxUnitElements = document.getElementsByClass('ad');
 
 const boxUnitAds = Array.prototype.map.call(boxUnitElements, (el, idx) => {
   const ad = new homepageAdPage.Ad(el, {
-    offset: -50,
+    offset: 50,
     sticky: true,
   });
 });

package.json

@@ -1,6 +1,6 @@
 {
   "name": "adjs",
-  "version": "2.0.0-beta.22",
+  "version": "2.0.0-beta.23",
   "description": "Ad Library to simplify and optimize integration with ad networks such as DFP",
   "main": "./core.js",
   "types": "./types.d.ts",

src/utils/scrollMonitor.ts

@@ -88,7 +88,7 @@ class ScrollMonitor {
   private static evaulateCurrentViewability = (ad: IScrollMonitorRegisteredAd, windowHeight: number) => {
     const bounding = ad.element.getBoundingClientRect();
 
-    const inView = (bounding.top + ad.offset) <= windowHeight && (bounding.top + bounding.height) >= 0;
+    const inView = (bounding.top - ad.offset) <= windowHeight && (bounding.top + bounding.height) >= 0;
     const fullyInView = bounding.top >= 0 && bounding.bottom <= windowHeight;
 
     if (fullyInView && !ad.fullyInView) {