Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] Duplicate sortable package present #10139

Open
1 task done
ChinmayMhatre opened this issue Jan 13, 2024 · 14 comments
Open
1 task done

[BUG] Duplicate sortable package present #10139

ChinmayMhatre opened this issue Jan 13, 2024 · 14 comments
Assignees
Labels
🛠 goal: fix undefined good first issue undefined 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)

Comments

@ChinmayMhatre
Copy link
Member

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

Production

Version of BioDrop (for example "v1.2.3")

2.99.3

Description

I noticed two sortablejs and react-sortable packages.
https://github.com/EddieHubCommunity/BioDrop/blob/main/package.json (Line 41 and 48 )

I searched for usage in the project But only found one being used in the project.
image

https://github.com/search?q=repo%3AEddieHubCommunity/BioDrop%20%22sortablejs%22&type=code

P.S. One could depend on the other but wanted to raise a request just in case.

Steps to Reproduce

Screenshots

No response

Do you want to work on this issue?

No

If "yes" to above, please explain how you would technically implement this

No response

@ChinmayMhatre ChinmayMhatre added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Jan 13, 2024
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
@eddiejaoude
Copy link
Member

Oh good spot, it looks like the sortablejs got added recently. I think it could be tested without this package and see if sorting works

@ChinmayMhatre ChinmayMhatre added 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and removed 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) labels Jan 18, 2024
@github-actions github-actions bot unlocked this conversation Jan 18, 2024
Copy link
Contributor

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@salisshuaibu11
Copy link

salisshuaibu11 commented Jan 19, 2024

i would like to take this one

@ChinmayMhatre
Copy link
Member Author

@salisshuaibu11 assigned it to you

@SaraJaoude SaraJaoude added the 🔢 points: 2 undefined label Jan 22, 2024
@SaraJaoude
Copy link
Member

As it has been two weeks since this was assigned to you @salisshuaibu11 and as no PR has been created, I am unassigning this issue so that we can give someone else the opportunity to work on it.

@dreamycodex
Copy link

Hi. Could I work on this please? Thank you.

@ChinmayMhatre
Copy link
Member Author

ChinmayMhatre commented Feb 14, 2024

@dreamycodex Assigned you the issue

ℹ️ ChinmayMhatre has some opened assigned issues: 🔧View assigned issues

@harshwasthere
Copy link

Hi, can I work on this issue? it is still assigned to someone but it's been a month and it is still unresolved.

@eugene4545
Copy link
Member

hello, can i be assigned to this issue?

@eddiejaoude
Copy link
Member

eddiejaoude commented Apr 22, 2024

@Harsh12Codes I couldn't see a PR either, so yes we can reassign it to you as 2 weeks has past since being assigned

ℹ️ eddiejaoude has some opened assigned issues: 🔧View assigned issues

@harshwasthere
Copy link

@eddiejaoude I found out that react-sortable.js is dependent on sortable.js, so there is no duplicate to remove.

image

@irungudennisnganga
Copy link

hello, can i be assigned to this issue?

@vinitmehta51
Copy link

@ChinmayMhatre:- Is this issue still needs to be kept open, as @Harsh12Codes confirms that both the packages are needed.
As one of the package is dependent on the other package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 goal: fix undefined good first issue undefined 🔢 points: 2 undefined 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

No branches or pull requests

9 participants