feat : Button component onClick and href prop #10156
Conversation
| @@ -34,6 +36,8 @@ export default function Button({ | |||
|
|
|||
| const button = ( | |||
| <button | |||
| href={href} | |||
There was a problem hiding this comment.
| href={href} |
Shouldn't we move the href prop to Link?
It seems like the intention was to use the href prop to determine whether to render a Link or a button. However, the return statement (return restProps.href ? link : button;) will always return a link (without an href) in this case.
Maybe we should move the href prop to the Link component. This way, when href is present, the Link component will be rendered with the href attribute, and when href is not present, a button will be rendered instead.
<Link
href={href}
Also we should change the return statement to href ? link : button;
There was a problem hiding this comment.
i was thinking of the same thing as well
|
Also, could you please edit your PR description and link your issue below the heading, with a hash, like this: |
nidhish-srivastava
changed the title
Fixes Issue
#10141
Changes proposed
Added onClick and href prop to the button component since they are the most used props while using the Button component so we get better intellisense while developing.
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers