Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[BUG] Tags Duplication #10349

Open
1 task done
feres7 opened this issue Apr 22, 2024 · 3 comments
Open
1 task done

[BUG] Tags Duplication #10349

feres7 opened this issue Apr 22, 2024 · 3 comments
Labels
🛠 goal: fix undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)

Comments

@feres7
Copy link

feres7 commented Apr 22, 2024

Has this bug been raised before?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Where did you find this bug?

Production on biodrop.io

Version of BioDrop (for example "v1.2.3")

v2.100.2

Description

When adding tags to your profile or event ticket tags can be duplicated
there is this text under the tags field (Separate tags with commas (tags cannot be duplicated and max 32 characters).) so the handler should not allow duplication and there is no condition for that

Steps to Reproduce

If you know the steps, follow the below format and provide steps to reproduce

For example:

  1. Go to Edit profile page.
  2. try to add tags with the same name

Screenshots

image
image

Do you want to work on this issue?

Yes

If "yes" to above, please explain how you would technically implement this

This is the handler responsible for it (handleKeyUp) I will just add a condition If a duplicate tag is found
image

@feres7 feres7 added 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet) 🛠 goal: fix undefined labels Apr 22, 2024
Copy link
Contributor

To reduce notifications, issues are locked until they are 🏁 status: ready for dev You can asked for this issue to be assigned (if not already assigned) and to be assigned. You can learn more in our contributing guide https://github.com/EddieHubCommunity/BioDrop/blob/main/CONTRIBUTING.md

@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
@feres7 feres7 mentioned this issue Apr 22, 2024
6 tasks
@amandamartin-dev
Copy link
Contributor

I believe this is not a bug and rather a decision so that users are not blocked from creating their profiles in any manner they wish. I will leave this in triage for other maintainers to weigh in. Thank you for the suggestion

@EddieHubCommunity EddieHubCommunity unlocked this conversation Jun 8, 2024
@eddiejaoude
Copy link
Member

Thank you for raising the issue.

I think at one point it was unique, I can't remember if it changed by mistake or was a design decision 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛠 goal: fix undefined 🚦 status: awaiting triage Waiting for maintainers to verify (please do not start work on this yet)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants