Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Fix: Make links page responsive on mobile view #10033

Closed
wants to merge 1 commit into from
Closed

Fix: Make links page responsive on mobile view #10033

wants to merge 1 commit into from

Conversation

sohail-313
Copy link

Fixes Issue

Closes #9907

Changes proposed

  • Implemented responsive design for the links page on mobile view.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Video Recording

links-responsive.mov

Note to reviewers

No specific notes for reviewers at the moment. The changes are straightforward and align with the outlined bugfix for the responsive issue. If you have any questions or suggestions, please feel free to let me know.

@github-actions github-actions bot added the issue linked Pull Request has issue linked label Dec 27, 2023
@sohail-313 sohail-313 changed the title Fix: Make links page responsive on mobile view (#9907) Fix: Make links page responsive on mobile view Dec 27, 2023
amandamartin-dev
amandamartin-dev suggested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@amandamartin-dev amandamartin-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! This looks good on the account page, but unfortunately is affecting the public facing profile. On that page the link text should remain left aligned (versus centered).

Please adjust so these changes only affect the account management view.

@sohail-313
Copy link
Author

Hello! This looks good on the account page, but unfortunately is affecting the public facing profile. On that page the link text should remain left aligned (versus centered).

Please adjust so these changes only affect the account management view.

Can you please share screenshot

@eddiejaoude
Copy link
Member

The other places links component is used does not look right. I think it might be better to hide the extra info (badges) on smaller screens and truncate the text

Screenshot 2024-01-15 at 09 26 31

@sohail-313
Copy link
Author

The other places links component is used does not look right. I think it might be better to hide the extra info (badges) on smaller screens and truncate the text

Screenshot 2024-01-15 at 09 26 31

Yes, it can be done. However, what if the user wants to edit those links?

@eddiejaoude
Copy link
Member

what if the user wants to edit those links?

don't hide the edit button, just the extra info, which they can then see and edit when they edit the link

@eddiejaoude
Copy link
Member

Closing PR as the author is not responding

@eddiejaoude eddiejaoude closed this Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amandamartin-dev amandamartin-dev amandamartin-dev requested changes

Assignees
No one assigned
Labels
issue linked Pull Request has issue linked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] links page in not responsive on mobile view
3 participants
@sohail-313 @eddiejaoude @amandamartin-dev