Skip to content

Commit 3488f0a

Browse files
authoredJul 29, 2024
Check return value of fscanf in LMS/XMSS KAT tests (open-quantum-safe#1874)
Signed-off-by: Spencer Wilson <[email protected]>
1 parent 841e903 commit 3488f0a

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed
 

‎tests/kat_sig_stfl.c

+8-2
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,10 @@ OQS_STATUS sig_stfl_kat(const char *method_name, const char *katfile) {
311311

312312
// Echo back remain
313313
if (FindMarker(fp_rsp, "remain = ")) {
314-
fscanf(fp_rsp, "%llu", &sigs_remain);
314+
if (EOF == fscanf(fp_rsp, "%llu", &sigs_remain)) {
315+
fprintf(stderr, "[kat_stfl_sig] %s ERROR: unable to read 'remain' from <%s>\n", method_name, katfile);
316+
goto err;
317+
};
315318
fprintf(fh, "remain = %llu\n", sigs_remain);
316319
} else {
317320
fprintf(stderr, "[kat_stfl_sig] %s ERROR: OQS_SIG_STFL_sigs_remaining failed!\n", method_name);
@@ -320,7 +323,10 @@ OQS_STATUS sig_stfl_kat(const char *method_name, const char *katfile) {
320323

321324
// Echo back max
322325
if (FindMarker(fp_rsp, "max = ")) {
323-
fscanf(fp_rsp, "%llu", &sigs_maximum);
326+
if (EOF == fscanf(fp_rsp, "%llu", &sigs_maximum)) {
327+
fprintf(stderr, "[kat_stfl_sig] %s ERROR: unable to read 'max' from <%s>\n", method_name, katfile);
328+
goto err;
329+
};
324330
fprintf(fh, "max = %llu\n", sigs_maximum);
325331
} else {
326332
fprintf(stderr, "[kat_stfl_sig] %s ERROR: OQS_SIG_STFL_sigs_total failed!\n", method_name);

0 commit comments

Comments
 (0)
Please sign in to comment.