Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make smtp_queue_fs::scan_folder rely on openat like everywhere else #80

Open
Ekleog opened this issue May 13, 2020 · 0 comments
Open

Make smtp_queue_fs::scan_folder rely on openat like everywhere else #80

Ekleog opened this issue May 13, 2020 · 0 comments
Labels
a:smtp-queue-fs Area: in the smtp-queue-fs crate c:easy Complexity: easy n:blocked Needs: resolution of another issue p:high Prio: medium t:bug Type: bug
Milestone
v0.1.0

Comments

@Ekleog
Copy link
Owner

Ekleog commented May 13, 2020

It's currently the only place where we use a non-openat version, except when opening the initial directory. This means that there's a race condition if a directory is being replaced between queue creation and folder scan; and things probably will go quite wrong.

Blocked on BurntSushi/walkdir#136 that's been redirected to BurntSushi/walkdir#23 for initial openat support
@Ekleog Ekleog added t:bug Type: bug c:easy Complexity: easy p:high Prio: medium n:blocked Needs: resolution of another issue a:smtp-queue-fs Area: in the smtp-queue-fs crate labels May 13, 2020
@Ekleog Ekleog added this to the v0.1.0 milestone May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:smtp-queue-fs Area: in the smtp-queue-fs crate c:easy Complexity: easy n:blocked Needs: resolution of another issue p:high Prio: medium t:bug Type: bug
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
1 participant
@Ekleog