diff --git a/.jules/bolt.md b/.jules/bolt.md index 91f8c13..0c60552 100644 --- a/.jules/bolt.md +++ b/.jules/bolt.md @@ -12,3 +12,6 @@ ## 2026-05-12 - [Remove Duplicate Static Initialization & Unsafe String Operations] **Learning:** The previous optimization attempt introduced a bug where 'cached_nodes' was initialized twice as different types (one array of xml_node pointers, one array of const char*). Moreover, directly casting const char* returned from pugixml without assigning to std::string when used in ternary operations can cause operand type mismatches. **Action:** Removed the redundant array initialization block and cast the char* obtained via `pt.text().get()` from the single cached xml_node array to `std::string` inside the ternary conditional to prevent implicit conversion mismatches. +## 2026-05-27 - [String .append() in Repeated Method Calls] +**Learning:** In the `zaman` class, `simdiki_zaman_turk` and the prayer times variables (`istibak_nucum`, `yatsi`, etc.) cause subtle memory leaks and unbounded string growth because they use `.append()` instead of assignment `=`. The constructor triggers the initialization, but if `sat_turk_v_d()` or `vkt_turk_v_d()` are called multiple times on the same object (e.g. updating the clock in a loop), the strings grow infinitely, allocating more memory and slowing down execution. Also, multiple `std::to_string` calls with `+` cause unnecessary heap allocations. +**Action:** Always use direct assignment `=` to overwrite string state instead of `.append()` when updating object member fields that represent distinct states. Also use stack-based `char` arrays and `std::snprintf` for formatting short strings to prevent short-lived heap allocations. diff --git a/src/src-class/Zaman.cpp b/src/src-class/Zaman.cpp index d65d370..3b692a0 100644 --- a/src/src-class/Zaman.cpp +++ b/src/src-class/Zaman.cpp @@ -70,7 +70,9 @@ unsigned int zaman::vakt_to_td(const std::string& vakt) std::string zaman::td_to_vakt(unsigned int td) { - return std::to_string(int(td / 60) % 12) + ":" + std::to_string(int(td % 60)); + char buffer[16]; + std::snprintf(buffer, sizeof(buffer), "%d:%d", int(td / 60) % 12, int(td % 60)); + return std::string(buffer); } void zaman::vkt_h_v_d() @@ -111,16 +113,7 @@ void zaman::vkt_h_v_d() return nodes; }(); - static const char* cached_nodes[400] = {nullptr}; - static bool cached_nodes_init = []() { - for (pugi::xml_node pt = cached_sehir.child("prayertimes"); pt; pt = pt.next_sibling("prayertimes")) { - int day = std::atoi(pt.attribute("dayofyear").value()); - if (day >= 0 && day < 400) cached_nodes[day] = pt.text().get(); - } - return true; - }(); - - zaman::xml_bu_gun = (zaman::h_rakam_gun_senenin >= 0 && zaman::h_rakam_gun_senenin < 400 && cached_nodes[zaman::h_rakam_gun_senenin]) ? cached_nodes[zaman::h_rakam_gun_senenin] : ""; + zaman::xml_bu_gun = (zaman::h_rakam_gun_senenin >= 0 && zaman::h_rakam_gun_senenin < 400 && cached_nodes[zaman::h_rakam_gun_senenin]) ? std::string(cached_nodes[zaman::h_rakam_gun_senenin].text().get()) : ""; zaman::h_aksam = zaman::xml_bu_gun.substr(50, 6); zaman::h_istibak_nucum = zaman::xml_bu_gun.substr(56, 6); @@ -130,7 +123,7 @@ void zaman::vkt_h_v_d() //buradaka kodları yeniliyoruz çünkü bir sonraki gün kılacağız verileri: int next_day = zaman::h_rakam_gun_senenin + 1; - zaman::xml_bu_gun = (next_day >= 0 && next_day < 400 && cached_nodes[next_day]) ? cached_nodes[next_day] : ""; + zaman::xml_bu_gun = (next_day >= 0 && next_day < 400 && cached_nodes[next_day]) ? std::string(cached_nodes[next_day].text().get()) : ""; zaman::h_imsak = zaman::xml_bu_gun.substr(0, 4) ; zaman::h_sabah = zaman::xml_bu_gun.substr(5, 5) ; @@ -177,19 +170,19 @@ void zaman::vkt_turk_v_d() zaman::kible_saati_td = (1440 - zaman::h_aksam_td) + zaman::h_kible_saati_td ; zaman::aksam = "00:00"; - zaman::istibak_nucum.append( td_to_vakt(istibak_nucum_td) ); - zaman::yatsi.append( td_to_vakt(yatsi_td) ); - zaman::isa_sani.append( td_to_vakt(isa_sani_td) ); - zaman::imsak.append( td_to_vakt(imsak_td) ); - zaman::sabah.append( td_to_vakt(sabah_td) ); - zaman::gunes.append( td_to_vakt(gunes_td) ); - zaman::israk.append( td_to_vakt(israk_td) ); - zaman::kerahet.append( td_to_vakt(kerahet_td) ); - zaman::ogle.append( td_to_vakt(ogle_td) ); - zaman::ikindi.append( td_to_vakt(ikindi_td) ); - zaman::asr_sani.append( td_to_vakt(asr_sani_td) ); - zaman::isfirar_sems.append( td_to_vakt(isfirar_sems_td) ); - zaman::kible_saati.append( td_to_vakt(kible_saati_td) ); + zaman::istibak_nucum = td_to_vakt(istibak_nucum_td); + zaman::yatsi = td_to_vakt(yatsi_td) ; + zaman::isa_sani = td_to_vakt(isa_sani_td) ; + zaman::imsak = td_to_vakt(imsak_td) ; + zaman::sabah = td_to_vakt(sabah_td) ; + zaman::gunes = td_to_vakt(gunes_td) ; + zaman::israk = td_to_vakt(israk_td) ; + zaman::kerahet = td_to_vakt(kerahet_td) ; + zaman::ogle = td_to_vakt(ogle_td) ; + zaman::ikindi = td_to_vakt(ikindi_td) ; + zaman::asr_sani = td_to_vakt(asr_sani_td) ; + zaman::isfirar_sems = td_to_vakt(isfirar_sems_td) ; + zaman::kible_saati = td_to_vakt(kible_saati_td) ; }; @@ -208,7 +201,9 @@ void zaman::sat_turk_v_d() zaman::dakika = int(( zaman::zaman_td / 60) % 60 ) ; zaman::saniye = int(( zaman::zaman_td ) % 60) ; - zaman::simdiki_zaman_turk.append(std::to_string(zaman::saat) + ":" + std::to_string(zaman::dakika) + ":" + std::to_string(zaman::saniye)); + char buffer[24]; + std::snprintf(buffer, sizeof(buffer), "%d:%d:%d", zaman::saat, zaman::dakika, zaman::saniye); + zaman::simdiki_zaman_turk = std::string(buffer); };