Skip to content

Commit 5dc3dbe

Browse files
committed
chore: added some FIXME comments to indicate what is not working in the demo
1 parent 9bb7dcf commit 5dc3dbe

File tree

7 files changed

+9
-0
lines changed

7 files changed

+9
-0
lines changed

src/ElectronNET.API/API/Clipboard.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ public Task<string> ReadTextAsync(string type = "")
4848
{
4949
BridgeConnector.Socket.Off("clipboard-readText-Completed");
5050

51+
// FIXME: System.InvalidOperationException: 'An attempt was made to transition a task to a final state when it had already completed.'
5152
taskCompletionSource.SetResult(text.ToString());
5253
});
5354

src/ElectronNET.API/Runtime/Services/LifetimeServiceBase.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ protected void TransitionState(LifetimeState newState)
8181
return;
8282
}
8383

84+
// FIXME: At launch the newState is 'Started' and this.state is 'Ready' throwing always an error
8485
if (newState < this.state)
8586
{
8687
throw new Exception($"Invalid state transition from {this.state} to {newState}: " + this.GetType().Name);

src/ElectronNET.WebApp/Controllers/AppSysInformationController.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public IActionResult Index()
1111
{
1212
if(HybridSupport.IsElectronActive)
1313
{
14+
// FIXME: System.TimeoutException: 'No response after 1000ms trying to retrieve value app.GetAppPathAsync()'
1415
Electron.IpcMain.On("app-info", async (args) =>
1516
{
1617
string appPath = await Electron.App.GetAppPathAsync();
@@ -27,6 +28,7 @@ public IActionResult Index()
2728
Electron.IpcMain.Send(mainWindow, "got-sys-info", homePath);
2829
});
2930

31+
// FIXME: It gives a result of 'Your screen is: undefinedpx x undefinedpx'
3032
Electron.IpcMain.On("screen-info", async (args) =>
3133
{
3234
var display = await Electron.Screen.GetPrimaryDisplayAsync();

src/ElectronNET.WebApp/Controllers/CrashHangController.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ public IActionResult Index()
1010
{
1111
if (HybridSupport.IsElectronActive)
1212
{
13+
// FIXME: Crashing is not working as expected. OnCrashed event is not being fired.
1314
Electron.IpcMain.On("process-crash", async (args) =>
1415
{
1516
string viewPath = $"http://localhost:{ElectronNetRuntime.AspNetWebPort}/crashhang/processcrash";

src/ElectronNET.WebApp/Controllers/MenusController.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ public IActionResult Index()
100100
return View();
101101
}
102102

103+
// FIXME: 'View Demo' button seems to do nothing
103104
private void CreateContextMenu()
104105
{
105106
var menu = new MenuItem[]

src/ElectronNET.WebApp/Controllers/ShortcutsController.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public IActionResult Index()
1111
{
1212
if (HybridSupport.IsElectronActive)
1313
{
14+
// FIXME: Seems to do nothing
1415
Electron.GlobalShortcut.Register("CommandOrControl+Alt+K", async () =>
1516
{
1617
var options = new MessageBoxOptions("You pressed the registered global shortcut keybinding.")

src/ElectronNET.WebApp/Controllers/UpdateController.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ public IActionResult Index()
2727
};
2828
Electron.AutoUpdater.OnUpdateDownloaded += async (info) => await Electron.Dialog.ShowMessageBoxAsync("Update complete!" + info.Version);
2929

30+
31+
// FIXME: System.TimeoutException: 'No response after 1000ms trying to retrieve value app.GetVersionAsync()'
3032
Electron.IpcMain.On("auto-update", async (args) =>
3133
{
3234
// Electron.NET CLI Command for deploy:

0 commit comments

Comments
 (0)