BIP341 txdata cannot be precomputed without spent outputs

sipa · psgreco · commit bc32ff6057ce · 2023-02-24T12:36:51.000-03:00
Github-Pull: #27122 Rebased-From: 95f12de (cherry picked from commit 95f12de)
diff --git a/src/script/interpreter.cpp b/src/script/interpreter.cpp
@@ -2585,7 +2585,7 @@ void PrecomputedTransactionData::Init(const T& txTo, std::vector<CTxOut>&& spent
         hashRangeproofs = GetRangeproofsHash(txTo);
         m_bip143_segwit_ready = true;
     }
-    if (uses_bip341_taproot) {
+    if (uses_bip341_taproot && m_spent_outputs_ready) {
         // line copied from GetTransactionWeight() in src/consensus/validation.h
         // (we cannot directly use that function for type reasons)
         m_tx_weight = ::GetSerializeSize(txTo, PROTOCOL_VERSION | SERIALIZE_TRANSACTION_NO_WITNESS) * (WITNESS_SCALE_FACTOR - 1) + ::GetSerializeSize(txTo, PROTOCOL_VERSION);

Original file line number	Diff line number	Diff line change
`@@ -2585,7 +2585,7 @@ void PrecomputedTransactionData::Init(const T& txTo, std::vector<CTxOut>&& spent`
`2585`	`2585`	`hashRangeproofs = GetRangeproofsHash(txTo);`
`2586`	`2586`	`m_bip143_segwit_ready = true;`
`2587`	`2587`	`}`
`2588`		`- if (uses_bip341_taproot) {`
	`2588`	`+ if (uses_bip341_taproot && m_spent_outputs_ready) {`
`2589`	`2589`	`// line copied from GetTransactionWeight() in src/consensus/validation.h`
`2590`	`2590`	`// (we cannot directly use that function for type reasons)`
`2591`	`2591`	`m_tx_weight = ::GetSerializeSize(txTo, PROTOCOL_VERSION \| SERIALIZE_TRANSACTION_NO_WITNESS) * (WITNESS_SCALE_FACTOR - 1) + ::GetSerializeSize(txTo, PROTOCOL_VERSION);`