Disabled tests in Elements

[instagibbs]

List of tests, and a brief description of why/difficulty of re-activation if not already activated:

• abandonconflict.py - Makes assumptions about fee values, CT values break this. Swapping out CT addresses may not be enough due to CT change. Need to add fee outputs for raw. Priority - Low
• assumevalid.py - Uses mininode to spend coinbase output. Moderate amount of effort. Need to re-add to extended test list. Priority - Low
• bip65-cltv-p2p.py - CLTV is always active, test is mostly checking various block versions which are always invalid over p2p. Probably would mostly be disabling. Disabled on extended test list. Priority - None
• bip65-cltv.py - Testing CLTV block version stuff. Priority - None
• bip68-112-113-p2p.py - Signaling for CSV BIP9. Priority - None
• bip68-sequence.py - Checking relay/consensus rules for version 2 transactions with sequence values set properly. mininode support required, fee outputs required. Priority - Medium
• bipdersig-p2p.py - Disabled on list, but working.
• blockchain.py - A few fields different. Disabled on the list. Easy to fix.
• bumpfee.py - bumpfee functionality isn't working for Elements. Likely decent amount of effort. Priority - Medium
• confidential_transactions.py - Working
• decodescript.py - Working
• disablewallet.py - Checks random stuff, none of which is applicable since we removed generatetoaddress for the time being. To re-add, we need to re-add generatetoaddress.
• forknotify.py - Working
• fundrawtransaction.py - Early return. Some fundraw testing is done in confidential_transactions.py, but errors seem manageable. Priority - Medium
• getblocktemplate_longpoll.py - Early return. Unknown amount of work. Priotity - Low
• getblocktemplate_proposals.py - Early return. Unknown amount of work. Priority - Low
• getchaintips.py - Working.
• httpbasics.py - Working.
• importmulti.py - Working
• importprunedfunds.py - Need to send all funds to single wallet, import blinding keys without rescan, or do unblinded send. Priority - Medium
• import-rescan.py - Need to make sure blinding key info is propagated as well, or do unblinded send. Priority - Medium
• invalidateblock.py - Working.
• invalidblockrequest.py - Failing to sync blocks, but this may be a mininode issue. Priority - High
• invalidtxrequest.py - Same as above. Priority - High
• keypool.py - Working.
• listsinceblock.py - Working
• listtransactions.py - opt-in RBF signaling test is disabled, rest works. Bizarre location for such a test since that feature has its own test. Priority - Low
• maxblocksinflight.py - Working.
• maxuploadtarget.py - Early return. Mininode failure. Priority - Low
• mempool_limit.py - rawtx failure. Priority - Medium
• mempool_packages.py - rawtx failure. Priority - Medium
• mempool_reorg.py - Early return. Signing failure? Assuming block reward. Priority - Medium
• mempool_resurrect_test.py - Early return. Assuming block reward. Priority - Medium
• mempool_spendcoinbase.py - Early return. Assuming block reward. Priority - Low
• merkle_blocks.py - Early return. Needs fee outputs in raw tx creation. Priority - Low
• multi_rpc.py - Working.
• nodehandling.py - Working.
• nulldummy.py - Failing in helper function. NULLDUMMY is always active on Elements. Priority - Low
• p2p-acceptblock.py - Early return. Failure in block syncing. Mininode? Priority - Medium-High
• p2p-compactblocks.py - Disabled on list. Failure to sync to same block? Mininode? Priority - Medium-High
• p2p-feefilter.py - Working.
• p2p-fullblocktest.py - Early return. Mininode support required. Priority - Medium
• p2p-leaktests.py - Working.
• p2p-mempool.py - Working.
• p2p-segwit.py - Disabled on list. Deals with transition details. Priority - Low
• p2p-timeouts.py - Working.
• p2p-versionbits-warning.py - Not in list. Mininode error. Priority - Very Low
• preciousblock.py - Working.
• prioritise_transaction.py - Early return. Requires mininode. Priority - Very Low
• proxy_test.py - Working.
• pruning.py - Working.
• rawtransactions.py - Early return. Largely incompatible with CT. confidential_tests.py should cover a lot of this. Priority - Low
• receivedby.py - Working.
• reindex.py - Working.
• replace-by-fee.py - Working in Re-activate transaction replacement functional test #264
• rest.py - Early return. Balance assumptions off. Should be easier to fix. Priority - Low
• rpcbind_test.py - Early return and commented out in list. Works otherwise.
• rpcnamedargs.py - Works.
• segwit.py - Early return. Makes assumptions about pre-activation. Priority - Medium-High
• sendheaders.py - Early return. Wait for getdata seems to timeout. Priority - High
• signmessages.py - Working.
• signrawtransactions.py - Early return. Address is invalid. Priority - Medium
• smartfees.py - Early return. Invalid addresses. Priority - Medium
• txn_clone.py - Early return. Assumptions about starting funds. Priority - Low
• txn_doublespend.py - Early return. Assumptions about starting funds. Priority - Low
• wallet-accounts.py - Disabled. We do not support accounts. We should just delete the test.
• walletbackup.py - Early return. dumpwallet doesn't store blinding keys. Unusable. We should just delete the test and RPC call.
• wallet-dump.py - Remove this test as well.
• wallet-hd.py - Working.
• wallet.py - Early-ish return. Priority - Medium
• zmq_test.py - Early return. Don't have ZMP installed on this machine, can't currently test. Priority - Low

Unit tests:

• addrman_tests - Works.
• allocator_tests - Works.
• amount_tests - Works.
• arith_uint256_tests.cpp
• assetsdir_tests
• base32_tests.cpp (???)
• base58_tests.cpp (???)
• base64_tests.cpp (???)
• bip32_tests.cpp
• blind_tests.cpp
• blockencodings_tests.cpp - Commented out
• bloom_tests.cpp - Partially disabled, need elements serialization for bloom test
• bswap_tests.cpp
• coins_tests.cpp - Commented out. Priority - High
• compress_tests.cpp
• crypto_tests.cpp
• cuckoocache_tests.cpp
• dbwrapper_tests.cpp
• DoS_tests.cpp
• getarg_tests.cpp
• hash_tests.cpp
• key_tests.cpp
• limitedmap_tests.cpp
• main_tests.cpp
• mempool_tests.cpp - Early return for MempoolIndexingTest. Test is hardcoded by txid sorting :(
• merkle_tests.cpp
• miner_tests.cpp - Commented out. Priority - High (breaks every rebase)
• multisig_tests.cpp
• netbase_tests.cpp
• net_tests.cpp
• pmt_tests.cpp
• policyestimator_tests.cpp
• pow_tests.cpp - Commented out. Useless for signed chains. Should just delete test.
• prevector_tests.cpp
• raii_event_tests.cpp
• reverselock_tests.cpp
• rpc_tests.cpp
• sanity_tests.cpp
• scheduler_tests.cpp
• scriptnum_tests.cpp
• script_P2SH_tests.cpp
• script_tests.cpp
• serialize_tests.cpp
• sighash_tests.cpp - Early return. Requires json files.
• sigopcount_tests.cpp
• skiplist_tests.cpp
• streams_tests.cpp

[instagibbs]

Will close this issue once #398 is complete as the complete test suite has been preserved thus far.

[instagibbs]

We have managed to preserve all the tests that make sense in 0.17. Closing.