common/test: Add a test to trigger the undefined behaviour

Add a test that reproduces the UB when the fix is not applied.

Author: Chandra Pratap

common/test/run-tlv_span.c

@@ -131,6 +131,22 @@ int main(int argc, char *argv[])
 	len = tlv_span(wire, 0, 1, &start);
 	assert(start == 0);
 	assert(len == strlen("0010b8538094dbd70d8a0f0439d8e64f766f") / 2);
+
+	/* Simulate an empty tlvstream */
+	wire = tal_arr(tmpctx, u8, 0);
+	len = tlv_span(wire, 0, UINT64_MAX, &start);
+	assert(start == 0);
+	assert(len == 0);
+
+	/* Simulate a TLV stream where the payload is shorter
+	 * than its length field indicates.
+	 */
+	wire = tal_hexdata(tmpctx, "0502beef0a03de", strlen("0502beef0a03de"));
+	len = tlv_span(wire, 0, UINT64_MAX, &start);
+	assert(start == 0);
+	/* The span should cover only the first valid record, which is 4 bytes long. */
+	assert(len == 4);
+
 	common_shutdown();
 	return 0;
 }