Skip to content

CHANNEL_STATE_MAX has wrong value #8417

@ksedgwic

Description

@ksedgwic
enum channel_state {
    DUALOPEND_OPEN_INIT = 1,
    CHANNELD_AWAITING_LOCKIN,
    CHANNELD_NORMAL,
        ...
    DUALOPEND_OPEN_COMMITTED,
    DUALOPEND_AWAITING_LOCKIN,
    CHANNELD_AWAITING_SPLICE,
    DUALOPEND_OPEN_COMMIT_READY,
};
#define CHANNEL_STATE_MAX CHANNELD_AWAITING_SPLICE

I think it should be set to DUALOPEND_OPEN_COMMIT_READY instead. Looks like a likely merge conflict.

All uses of CHANNEL_STATE_MAX should be carefully considered as well ...

thumbs up from @niftynei in #core-lightning-dev-chat:
https://discord.com/channels/899980449231814676/899989708065632276/1392940900493295746

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions