Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing key in dictionary when loading tasks. #2303

Open
giuliolovisotto opened this issue Sep 16, 2024 · 0 comments · May be fixed by #2304
Open

Missing key in dictionary when loading tasks. #2303

giuliolovisotto opened this issue Sep 16, 2024 · 0 comments · May be fixed by #2304
Labels
bug Something isn't working.

Comments

@giuliolovisotto
Copy link

Here, at L274, the item "task" has been popped from the dictionary in some execution paths :

lm-evaluation-harness/lm_eval/tasks/__init__.py

Lines 267 to 276 in fb963f0

if self._config_is_python_task(config):
if self._class_has_config_in_constructor(config["class"]):
task_object = config["class"](config=config)
else:
task_object = config["class"]()
if isinstance(task_object, ConfigurableTask):
# very scuffed: set task name here. TODO: fixme?
task_object.config.task = config["task"]
else:
task_object = ConfigurableTask(config=config)

Specifically, this one:

lm-evaluation-harness/lm_eval/tasks/__init__.py

Line 337 in fb963f0

name = name_or_config.pop("task")

I can open a small PR.
@giuliolovisotto giuliolovisotto linked a pull request Sep 16, 2024 that will close this issue
Open
@baberabb baberabb added the bug Something isn't working. label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing key in custom task loading. giuliolovisotto/lm-evaluation-harness
2 participants
@giuliolovisotto @baberabb