pfacing resets player velocity to 0

[LadyCailin]

As this is a commonly used function, this can be used to avoid fall damage when run just before landing. Player velocity should be looked up before the location set, then set back to that immediately afterwards. In the meantime, this can be worked around by doing this in code, but this shouldn't be necessary. Untested, but likely works with set_ploc as well, though perhaps this is not a problem.

Discussion wanted, as this is a breaking change.

[PseudoKnight]

pfacing() has always just been a teleport and behaved this way. Even re-applying the velocity will still result in jutter.

Technically the real solution is to use relative teleport flags. This was only possible via nms until it was added to Paper earlier this year in 1.19.

https://jd.papermc.io/paper/1.19/org/bukkit/entity/Player.html#teleport(org.bukkit.Location,org.bukkit.event.player.PlayerTeleportEvent.TeleportCause,boolean,boolean,io.papermc.paper.entity.RelativeTeleportFlag...)

[Pieter12345]

Might it be possible to maintain velocity through the Bukkit API, then we should consider adding an optional keepVelocity or resetVelocity boolean parameter to pfacing(). This solution is possible without changing existing behavior.