Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sheet] Open, slotted Sheets, Modals, and Dialogs prevent page interaction #11657

Open
2 of 6 tasks
macandcheese opened this issue Mar 1, 2025 · 2 comments
Open
2 of 6 tasks
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Mar 1, 2025

Check existing issues

Actual Behavior

The Sheet component can be slotted, and constrained, to a particular region by using the "sheets" slot of Shell.

Currently - this behavior prevents user interaction with page elements, even those outside the constrained region of the "sheets" slot.

Expected Behavior

This shouldn't occur - users should be free to interact with any region not covered by the Sheet's scrim.

Reproduction Sample

sheet - https://codepen.io/mac_and_cheese/pen/dPyNjwe?editors=1000
dialog - https://codepen.io/Ditwan-Price/pen/EaxWoBp?editors=1010
modal - https://codepen.io/Ditwan-Price/pen/vEYxdyO?editors=1010

Reproduction Steps

  1. Open Codepen
  2. Open the Sheet, Dialog, or Modal and try to interact with other page elements (Action bars, etc.)
  3. Notice click events do not work.
  4. Switch the import to 2.13.2
  5. Repeat
  6. Notice the click events work as expected.

Reproduction Version

3.x

Relevant Info

No response

Regression?

2.13.2

Priority impact

impact - p1 - need for current milestone

Impact

Regression

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@macandcheese macandcheese added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. regression Issues that are caused by changes in a release, but were working before that. labels Mar 1, 2025
@github-actions github-actions bot added the impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone label Mar 1, 2025
@macandcheese
Copy link
Contributor Author

Note: Verify this is not occurring for other components - Alert, Dialog, etc., that have named slots in Shell or other components.

@DitwanP
Copy link
Contributor

DitwanP commented Mar 3, 2025

Looks like this also effects other slotted components.

Doesn't seem to be an issue for alerts though:

@DitwanP DitwanP changed the title [Sheet] Open, slotted Sheets prevent page interaction [Sheet] Open, slotted Sheets, Modals, and Dialogs prevent page interaction Mar 3, 2025
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 5 A few days of work, definitely requires updates to tests. labels Mar 3, 2025
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 5 A few days of work, definitely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Development

No branches or pull requests

3 participants