Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Scrim] Update default scrim color to be more transparent #11666

Open
1 of 6 tasks
macandcheese opened this issue Mar 4, 2025 · 2 comments
Open
1 of 6 tasks

[Scrim] Update default scrim color to be more transparent #11666

macandcheese opened this issue Mar 4, 2025 · 2 comments
Labels
0 - new New issues that need assignment. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@macandcheese
Copy link
Contributor

Check existing issues

Description

The Scrim component has very little transparency by default.

In particular - in dark mode - Components like Dialog and Sheet that render Scrim, wind up with pretty low contrast between their default content containers and this Scrim.

In both light and dark mode - It's also just generally pretty hard to see the page context behind the Scrim.

Adjusting our defaults should help alleviate most of these issues, while still allowing adjustment via css properties for custom needs.

Acceptance Criteria

Scrim's transparency treatment is adjusted for both light and dark mode. From a design standpoint, we could also look at whether a Dialog or Scrim in light mode should render dark mode Scrim.

Relevant Info

Specific to dark mode - #3122 may provide additional improvement.

Which Component

Scrim

Dialog, Sheet would improve by way of this change but shouldn't require any direct change.

Example Use Case

Current Propose something like:
Image Image
Image Image

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

N/A

@macandcheese macandcheese added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Mar 4, 2025
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Mar 4, 2025
@macandcheese macandcheese added design Issues that need design consultation prior to development. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists labels Mar 4, 2025
@allyshah
Copy link

allyshah commented Mar 5, 2025

The Dashboards team is tracking this issue. This issue corresponds with our own issue: https://devtopia.esri.com/WebGIS/arcgis-dashboards/issues/8040

While our core issue is that there is low contrast between the dark mode dialogue and scrim, we would like to be sure that a "more transparent" scrim does not introduce visual noise as more of what's behind the scrim shows through- a scenario which can also result in low contrast between dialogue and scrim.

Thank you!

@geospatialem geospatialem added the ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. label Mar 5, 2025
@macandcheese
Copy link
Contributor Author

macandcheese commented Mar 5, 2025

Makes sense! Note that there are times when "more of what's behind the scrim" showing through is desirable for some components and workflows (for instance showing what's behind Sheet / scrim with a lighter transparency while a user performs a quick action) - so while our updated default hopefully strikes that balance, overrides are possible / encouraged as needed with css properties for specific cases.

GH for example has a very transparent treatment.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants