Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/hide reset filter from the filte modal #868

Open
skrishn opened this issue Sep 17, 2024 · 4 comments
Open

Remove/hide reset filter from the filte modal #868

skrishn opened this issue Sep 17, 2024 · 4 comments
Assignees
Labels
Reporter 4.x Crowdsource Reporter (new)
Milestone

Comments

@skrishn
Copy link
Collaborator

skrishn commented Sep 17, 2024

Related to this enhancement #647

Having two reset filters look redundant and let's hide/remove the first one as highlighted.

image

@skrishn skrishn added the Reporter 4.x Crowdsource Reporter (new) label Sep 17, 2024
@skrishn skrishn added this to the 2024.R03 milestone Sep 17, 2024
@sumitzarkar
Copy link
Collaborator

@jmhauck

To implement this we need updates in the instant app component to make reset buttons visibility configurable, just like we have a closeBtn.

FYI - @skrishn

@jmhauck
Copy link
Collaborator

jmhauck commented Sep 19, 2024

@sumitzarkar I added another boolean prop resetBtn that when false will prevent the drawing of the "Reset Filter" button in IAC 1.0.0-beta.260. It's in our develop branch now

@sumitzarkar
Copy link
Collaborator

@jmhauck

We are able to use this prop, after setting it to false the reset button is not shown.
We will deliver the code in next code drop

@sumitzarkar
Copy link
Collaborator

@skrishn

Solution

Passed false value to resetBtn for the instant-apps-filter-list to hide the reset button


Dev Checklist

Items Is required Status Comments
Required NLS changes? No
Required Backward compatibility No
Required 508 No
Need Sanitize? No

Impact Analysis Report

Impacted Areas Comments
Have Configuration changes? No
Have Runtime changes? Yes
Impact on RTL No
Impact on instant app filter list Single reset button should shown at the footer of the filter list component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reporter 4.x Crowdsource Reporter (new)
Projects
None yet
Development

No branches or pull requests

3 participants