Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding new variable without explicit title as column in GUI #347

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

takluyver
Copy link
Member

This should close #346.

@takluyver takluyver added the bug Something isn't working label Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.35%. Comparing base (16dfe49) to head (9a31521).
Report is 54 commits behind head on master.

Files with missing lines Patch % Lines
damnit/gui/table.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #347   +/-   ##
=======================================
  Coverage   75.35%   75.35%           
=======================================
  Files          32       32           
  Lines        4974     4974           
=======================================
  Hits         3748     3748           
  Misses       1226     1226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmichela
Copy link
Member

LGTM

@takluyver takluyver merged commit e2677b0 into master Oct 17, 2024
5 of 6 checks passed
@takluyver takluyver deleted the fix/col-no-title branch October 17, 2024 11:59
@takluyver
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI crash when new column sent from backend
2 participants