-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Re)process runs from the GUI #285
Conversation
d2fb95e
to
9327aa5
Compare
Could you also add an option on right click? |
it'd also be nice to check if new variables exist in the context file that were never processed, otherwise it will always be skipped, unless one selects all variables. |
I'll add a right-click option. 👍 For new variables: would it be a decent compromise to update the variables whenever you successfully save the context file in the GUI? Loading the context file often takes a few seconds, so doing it when showing this dialog either means an awkward pause before showing it, or a janky update after the list shows up, neither of which seem like great UX. I'm also wondering about an option to process only variables which don't already have results, to fill in newly added variables. |
9327aa5
to
9c0d5fe
Compare
It is really that long to validate the file? 🤔 |
I'm thinking that I would be nice to have a visual indicator of the runs processing, particularly in this case of processing from the gui. But I think we don't have a way to monitor slurm jobs status yet, right? |
Co-authored-by: Thomas Michelat <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
=========================================
Coverage ? 74.74%
=========================================
Files ? 32
Lines ? 4835
Branches ? 0
=========================================
Hits ? 3614
Misses ? 1221
Partials ? 0 ☔ View full report in Codecov by Sentry. |
It's now common/normal to use a different Python environment for evaluating the context file from running the DAMNIT application. So validating it means launching a subprocess and then loading all the modules it imports. Between GPFS, which isn't great for lots of small files, and xarray, which gets its
Yup, I'm also planning that, but I wanted to do this first. |
I'm happy with the current state, feel free to merge. LGTM |
Thanks for the review! |
Another attempt at this, now that processing happens in Slurm.
Closes #39