Merge pull request #102083 from software-mansion-labs/insights/fix-empty-state-scroll

[Insights] fix: Insights empty state is not scrollable in landscape mode

Author: luacmartins

src/pages/Insights/InsightsDashboard.tsx

@@ -84,12 +84,15 @@ function InsightsDashboardContent({dashboardID, hash, state, filters, onRetry}:
         );
     }
 
-    if (state === INSIGHTS_DASHBOARD_STATE.NO_EXPENSES) {
-        return <InsightsNoExpensesState />;
-    }
-
-    if (state === INSIGHTS_DASHBOARD_STATE.EMPTY) {
-        return <InsightsEmptyState />;
+    if (state === INSIGHTS_DASHBOARD_STATE.NO_EXPENSES || state === INSIGHTS_DASHBOARD_STATE.EMPTY) {
+        return (
+            <ScrollView
+                contentContainerStyle={[styles.flexGrow1, styles.flexShrink0]}
+                addBottomSafeAreaPadding
+            >
+                {state === INSIGHTS_DASHBOARD_STATE.NO_EXPENSES ? <InsightsNoExpensesState /> : <InsightsEmptyState />}
+            </ScrollView>
+        );
     }
 
     const {headlineChart, supportingCharts} = INSIGHTS_DASHBOARD_SPECS[dashboardID];

src/pages/Insights/states/InsightsEmptyState.tsx

@@ -19,6 +19,7 @@ function InsightsEmptyState() {
             headerContentStyles={[styles.insightsEmptyStateIllustration]}
             title={translate('insightsPage.emptyState.title')}
             subtitle={translate('insightsPage.emptyState.subtitle')}
+            minModalHeight={0}
         />
     );
 }

src/pages/Insights/states/InsightsNoExpensesState.tsx

@@ -24,6 +24,7 @@ function InsightsNoExpensesState() {
             headerContentStyles={[styles.insightsEmptyStateIllustration]}
             title={translate('insightsPage.noExpensesState.title')}
             subtitle={translate('insightsPage.noExpensesState.subtitle')}
+            minModalHeight={0}
             buttons={[
                 {
                     buttonText: translate('iou.createExpense'),