Ensure the Reports Bulk action correctly does not allow deleting CC card transactions

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation (hyperlinked to channel name):

Action Performed:

Break down in numbered steps

1. Import CC card transactions so users are not allowed to delete them
2. Go to Reports page
3. Bulk select also the transactions that cannot be deleted

Expected Result:

Describe what you think should've happened

The Delete option should not be visible if one of the selected transactions cannot be deleted

Actual Result:

Describe what actually happened

Even if you select all or just one cc transaction that does not have the CONST.TRANSACTION.LIABILITY_TYPE.ALLOW liability type, we show the option to delete the transaction (but it cannot be deleted in the backend)

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Shahidullah-Muffakir]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-27 22:44:33 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

delete btn is showing for CC transaction with no deletion right

What is the root cause of that problem?

we are not checking the deletion right here based on Liability Type:

App/src/pages/Search/SearchPage.tsx

Line 260 in 674f07d

const shouldShowDeleteOption = !isOffline && selectedTransactionsKeys.every((id) => selectedTransactions[id].canDelete);

Like we check in the report details page:

App/src/pages/ReportDetailsPage.tsx

Line 325 in 845811a

const isCardTransactionCanBeDeleted = canDeleteCardTransactionByLiabilityType(iouTransactionID);

App/src/libs/ReportUtils.ts

Lines 2260 to 2267 in 845811a

	function canDeleteCardTransactionByLiabilityType(iouTransactionID?: string): boolean {
	const transaction = getTransaction(iouTransactionID ?? CONST.DEFAULT_NUMBER_ID);
	const isCardTransaction = isCardTransactionTransactionUtils(transaction);
	if (!isCardTransaction) {
	return true;
	}
	return transaction?.comment?.liabilityType === CONST.TRANSACTION.LIABILITY_TYPE.ALLOW;
	}

What changes do you think we should make in order to solve the problem?

Update that condition in the SearchPage , to check for the Liability type as:

App/src/pages/Search/SearchPage.tsx

Line 260 in 674f07d

const shouldShowDeleteOption = !isOffline && selectedTransactionsKeys.every((id) => selectedTransactions[id].canDelete);

        const shouldShowDeleteOption = !isOffline && selectedTransactionsKeys.every((id) => selectedTransactions[id].canDelete && canDeleteCardTransactionByLiabilityType(id));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

[mountiny]

@Shahidullah-Muffakir Does the selectedTransactions have the liability type information?

[Shahidullah-Muffakir]

@Shahidullah-Muffakir Does the selectedTransactions have the liability type information?

I think we only need the transactionID, as we get the transaction details inside the canDeleteCardTransactionByLiabilityType from onyx

[mountiny]

I think we only need the transactionID, as we get the transaction details inside the canDeleteCardTransactionByLiabilityType from onyx

Yes, but what if the transaction is not in onyx, we need to rely on what the Search command returned

[Shahidullah-Muffakir]

Thank you, then it seems directly updating this condition would be better, as it has the transaction data from the search results:

App/src/components/Search/index.tsx

Line 241 in 4707dda

canDelete: transaction.canDelete,

App/src/components/Search/index.tsx

Line 262 in 4707dda

canDelete: transaction.canDelete,

App/src/components/Search/index.tsx

Line 111 in a0886ed

canDelete: item.canDelete,

and we will map the comment property here:

App/src/components/Search/index.tsx

Lines 56 to 63 in a0886ed

	function mapTransactionItemToSelectedEntry(item: TransactionListItemType): [string, SelectedTransactionInfo] {
	return [
	item.keyForList,
	{
	isSelected: true,
	canDelete: item.canDelete,
	canHold: item.canHold,
	isHeld: isOnHold(item),

[allgandalf]

we found an odd case, working on it...